chaostoolkit / chaostoolkit-lib

The Chaos Toolkit core library
https://chaostoolkit.org/
Apache License 2.0
77 stars 46 forks source link

fix(hypothesis): clear up error message when expect fails #269

Closed mattiascockburn closed 11 months ago

mattiascockburn commented 11 months ago

If the expect string includes strings that should be replaced the debug/error message should include the final expect string where all placeholders are substituted. Otherwise the user is lead to believe that the substitution itself failed.

mattiascockburn commented 11 months ago

@Lawouach do you think this is a good idea or should i rework this?

Lawouach commented 11 months ago

@mattiascockburn I think it makes a lot of sense

Lawouach commented 11 months ago

It seems that breaks at least one test. That's good :)

mattiascockburn commented 11 months ago

@Lawouach hopefully i fixed it up enough :-)

Lawouach commented 11 months ago

Hey @mattiascockburn sorry for being a tad slow on this one. I cannot see the changelog entry in any of the commits though.

mattiascockburn commented 11 months ago

@Lawouach sorry i was just being stupid and forgot to add my changes to the commit :-/