chaosvolt / cdda-arcana-mod

Arcana and Magic Items mod for Cataclysm: Dark Days Ahead
Other
164 stars 62 forks source link

Hunter visor is not working? #289

Closed YuPro closed 2 years ago

YuPro commented 2 years ago

Looks like IR vision is not working because of blindness. At least in my game activated visor works like blindfold with hear protection (and flash protection, but I don't think it's matters when you're blind).

Or I just don't understand something?

chaosvolt commented 2 years ago

The clairvoyance should be working at least, unless DDA broke something.

YuPro commented 2 years ago

2022-10-07_18-30-02 2022-10-07_18-30-27 2022-10-07_18-31-09

Modlist:

[ "dda", "no_npc_food", "no_fungal_growth", "package_bionic_professions", "secronom", "aftershock", "Arcana", "Cata++", "magiclysm", "xedra_evolved", "MST_Extra", "DinoMod", "World_on_fire", "extra_mut_scens", "translate_dialogue", "Dorf_Life", "Tankmod_Revived", "Arcana_aftershock_Patch", "Arcana_Cata++_Patch", "Arcana_Dinomod_Patch", "Arcana_Magiclysm_Patch", "Graphical_Overmap_SDG_Arcana", "Graphical_Overmap_SDG_Cata++", "Graphical_Overmap_SDG_secronom", "Graphical_Overmap_SDG", "sees_player_retro", "sees_player_hitbutton", "alt_map_key" ]

chaosvolt commented 2 years ago

Oh god fucking damnit they really did break it.

chaosvolt commented 2 years ago

Okay, no. It's not that. I tested removing the BLIND flag from the active mask of insight: image

You need to go open an issue for it: https://github.com/CleverRaven/Cataclysm-DDA/issues\

The issue is a DDA one, not an Arcana one, some code change has straight-up broke clairvoyance outright.

chaosvolt commented 2 years ago

To clarify further: mutations with the SUPER_CLAIRVOYANCE flag (as given by the debug clairvoyance artifact) work, as does the regular CLAIRVOYANCE flag as can be verified by casting Magic Sign: Clairvoyance. But the CLAIRVOYANCE_PLUS flag no longer works, that's the one mask of insight was using.

chaosvolt commented 2 years ago

Wait, that's odd...granting the mutation Debug Clairvoyance, the version that has the CLAIRVOYANCE_PLUS flag, works fine. But not the version used by the mask of insight. Despite the fact that the Clairvoyance spell ALSO uses a custom mutation but it works fine? Uh...something is definitely fucky here and I'm still trying to figure out what.

chaosvolt commented 2 years ago

AHAH! For whatever reason, having it defined as an actual enchantment via passive_effects is broken. But when I convert the enchantment's effects entirely into being defined within relic_data, it works.

YuPro commented 2 years ago

Still don't work for me, any tips on how I could update mod wrong?

P.S Satchel is working without errors.

P.S.S I deleted old folder and changed it with new one.

YuPro commented 2 years ago

I tested it a little bit, looks like it don't give me «Hunter's True Sight» mutation (changed "player_display" to true). Mutation is working with pretty big AOE if I add it through debug.

YuPro commented 2 years ago

Ok, it's only Hunter's Visor that's not working, Mask is OK, will look what is missing now.

chaosvolt commented 2 years ago

Old versions of the item will still have the old broken enchantment, did you try spawning in a new hunter's visor?

YuPro commented 2 years ago

Thanks, it worked.

Game cashes that kind of things? Interesting mechanics decision, do you know if it's to be more save compatible?

Also, does that mean that I need to respawn mantle of shadows if I have one? What about Stinger Flute, item is updated or it's just effect? Satchel is ok I believe.