search

chaosvolt / cdda-arcana-mod

Arcana and Magic Items mod for Cataclysm: Dark Days Ahead
Other
155 stars 62 forks source link

Some mutation/cell biology specific fields ported to enchantments. #411

Closed waveyl closed 4 months ago

waveyl commented 4 months ago

See DDA#72034 and #72106

chaosvolt commented 4 months ago

Uuuugh. I'll fix this tomorrow or when I can get time, last few days have been busy.

chaosvolt commented 4 months ago

Oh, https://github.com/chaosvolt/cdda-arcana-mod/pull/412 fixes this if I recall.

chrsrns commented 4 months ago

CDDA commit 9f08089 and Arcana commit d52e431 still produces errors regarding the mutations.

chaosvolt commented 4 months ago

Fucking auuuugh. Been busy with IRL a fair bit lately.

chaosvolt commented 4 months ago

Okay, that should do it. I'm gonna have to chuck a Cata++ fix at Noct too, possibly later today if stuff doesn't come up.

I also see @GuardianDll has a part three out already which...I dunno if I'll be able to find time to set aside a draft PR so I won't be blindsided by this or not but we'll see.

GuardianDll commented 4 months ago

yeah, it's not the end, i plan to port all single numerical fields from mutations and cbms to enchantments sorry for caused issues

chaosvolt commented 4 months ago

No worries, just might be slow to update things since been juggling stuff.

waveyl commented 4 months ago

@chaosvolt #72173 merged