search

chaosvolt / cdda-arcana-mod

Arcana and Magic Items mod for Cataclysm: Dark Days Ahead
Other
155 stars 62 forks source link

[DDA] Convert martial arts technique attack_vectors to new format #434

Closed b3brodie closed 1 month ago

b3brodie commented 1 month ago

In https://github.com/CleverRaven/Cataclysm-DDA/pull/73064 the format for attack_vector definitions changed to allow for extra specificity/unhardcoding/etc. This PR converts the old attack vector definitions to the new ones based on the linked PR's example with the DDA techniques.

Note: The current attack_vector definitions do not throw a startup error but will fail when actually trying to use them.

chaosvolt commented 1 month ago

Note: The current attack_vector definitions do not throw a startup error but will fail when actually trying to use them.

What's needed to make them work? Or is it a case of something broken on DDA's end?

b3brodie commented 1 month ago

Note: The current attack_vector definitions do not throw a startup error but will fail when actually trying to use them.

What's needed to make them work? Or is it a case of something broken on DDA's end?

I think I could have worded that better. I was trying to talk about the existing attack vectors from before I changed them with the PR. They didn't throw startup errors despite no longer being supported, but trying to actually use them would throw an error. All of that was fixed with this PR update to the correct vectors.

chaosvolt commented 1 month ago

Oh, I see what you mean, thanks then.