chaoszhang / ASTER

Accurate Species Tree EstimatoR: a family of optimation algorithms for species tree inference (including ASTRAL & CASTER)
GNU Affero General Public License v3.0
91 stars 10 forks source link

master and not caster (README and makefile)? #19

Closed nylander closed 8 months ago

nylander commented 8 months ago

Dear @chaoszhang !

Thank you for providing the ASTER code project. I was looking at your makefiles and it struck me:

Is CASTER permanently renamed to MASTER?

This name change seems not to be reflected in the README.md?

Importantly, these changes are not made in makefiles, making automation of the installation process a bit harder.

First rule in makefile from downloaded release asset (https://github.com/chaoszhang/ASTER/archive/refs/tags/v1.15.tar.gz)

all: dir astral astral-pro astral-hybrid master-site master-pair

First rule in makefile from the master/Linux/Windows/MacOS/develop branches:

all: dir astral astral-pro astral-hybrid caster-site caster-site_branchlength caster-pair waster-site

Cheers

/Johan

chaoszhang commented 8 months ago

The other way around. I removed the old releases just now.

nylander commented 8 months ago

Thank you for clarifying this! Yours Johan