chaotic-aur / kde-git-WIP-ALPHA

kde-git very WIP and very alpha
GNU General Public License v3.0
3 stars 1 forks source link

remove all hard coded absolute paths #4

Open fanzhuyifan opened 7 months ago

fanzhuyifan commented 7 months ago

Currently most paths in the shell scripts are hard coded absolute paths, making it difficult for users to run those from different folders.

alexjp commented 7 months ago

yeah, this one is easy and will be "next TODO"!

alexjp commented 7 months ago

Should be done in b656cb51868dddcf7e505ea77baf88f360b6bf6a

NOTICE: now there is a settings.toml file needed to be adapted!

Closing when confirmed :)

fanzhuyifan commented 7 months ago

Looks good, but I am not sure how to install the chaotic tool (on vanilla Arch)

alexjp commented 7 months ago

Can you check out the latest commit ? Adapt in the settings.toml, the chaotic mkd to makepkg ..... .

The command is called with one argument, which is the folder.

I added the file arch_builder_cmd_example.sh as an example of such a script (making that file the build.cmd of settings.toml) (also, the file should be in the same folder as builder.nu)

fanzhuyifan commented 7 months ago

The log file is needed:

#!/usr/bin/env bash
LOGFILE="$(pwd)/$1.log"
cd "$1"
makepkg -s -f -i | tee "$LOGFILE"

Tried builder.nu. It doesn't seem to be honoring the build and archive settings. The locks setting seems honored. Otherwise works fine.

fanzhuyifan commented 7 months ago

https://github.com/chaotic-aur/kde-git-WIP-ALPHA/blob/a515cd559fbc951bb646d8dfa89850a720a11164/builder.nu#L105

and

https://github.com/chaotic-aur/kde-git-WIP-ALPHA/blob/a515cd559fbc951bb646d8dfa89850a720a11164/builder.nu#L115

should also be updated.

alexjp commented 7 months ago

will check those out. I also noticed, testing it on my local machine, that it would be cool to "use" the previous builds (of course, this is unacceptable for chaotic).

alexjp commented 6 months ago

https://github.com/chaotic-aur/kde-git-WIP-ALPHA/blob/a515cd559fbc951bb646d8dfa89850a720a11164/builder.nu#L105

and

https://github.com/chaotic-aur/kde-git-WIP-ALPHA/blob/a515cd559fbc951bb646d8dfa89850a720a11164/builder.nu#L115

should also be updated.

that line at 115, it should run the command set in settings file, so it is not running "chaotic mkd".