search

chaotic-aur / packages

The packages Mason, what do they mean? (Package requests and bug reports here) 📑
https://aur.chaotic.cx
326 stars 20 forks source link

[Bug] prboom-plus. No OpenGL! #2165

Closed yum13241 closed 1 year ago

yum13241 commented 1 year ago

What happens?

No OpenGL support, can't be chosen as an option.

What is expected to happen?

OpenGL should be an option.

If possible, please attach logs

No response

More information

Do the following:

  1. Install prboom-plus.
  2. Launch it with an IWAD (if you don't own Doom, get Freedoom!)
  3. ESC > Options > General > Video Mode. OpenGL should be an option, perhaps it's not compiled in?

Also, when you launch prboom-plus for the first time, mute your speakers and change the MIDI Device to smth that's NOT "SDL". Otherwise you'll get earraped. Then restart the game.

Technetium1 commented 1 year ago

@yum13241 can you please open an issue upstream and link to this issue? I don't see compile flags relating to OpenGL anywhere. There are not any big differences in https://aur.archlinux.org/packages/prboom-plus-um-git

Earrape problem might warrant a second separate issue.

yum13241 commented 1 year ago

What the earrape problem does is loop sounds even after they're supposed to stop. So shooting the pistol will sound like POWPOWPOWPOWPOWPOWPOWPOWPOWPOWPOWPOWPOW... instead of just POW!

Upstream says the following:

  PrBoom+ is in maintenance mode!

  This means that only bug fixes and portability fixes will get applied.

  DSDA-Doom is considered PrBoom+'s successor and is in active development.
  Please consider taking any feature requests there instead:
fabiangreffrath commented 1 year ago

Could you please, as a very first step, upgrade the package to at least the released 2.6.2 version?

yum13241 commented 1 year ago

Ask @Technetium1, I have nothing to do with the building process.

If the package on the AUR prboom-plus is outdated, bug them and flag it as outdated.

Technetium1 commented 1 year ago

@fabiangreffrath both are at 2.6.2:

chaotic-aur/prboom-plus 2.6.2-1
chaotic-aur/prboom-plus-um-git 2.6.2.r53.gbfe08a0f-1

@yum13241 the sound issue seems like it qualifies as a valid bug to fix, rather than a feature request. If it fails the same on DSDA-Doom, definitely open the bug report there instead!

yum13241 commented 1 year ago

The bug does NOT happen in DSDA-Doom.

I opened the bug report on PrBoom+'s github a few days back.

fabiangreffrath commented 1 year ago

An OpenGL implementation must be available at build time for the OpenGL renderer.

I opened the bug report on PrBoom+'s github a few days back.

Which one?

Technetium1 commented 1 year ago

Build log: prboom-plus.log Should be libglvnd

fabiangreffrath commented 1 year ago

OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY", so for compatibility with CMake 3.10 and below the legacy GL library will be used.

This is a lie:

-- Found OpenGL: /usr/lib/libOpenGL.so

Could you please apply this patch?

https://github.com/coelckers/prboom-plus/commit/921adf17e02408e7f0a06b59df4a4c07d716ee35

xiota commented 1 year ago

Has this been resolved? Looks like prboom-plus has had a few updates since this was opened.

$ pacman -Ss prboom-plus
chaotic-aur/prboom-plus 2.6.66-1
    An advanced, Vanilla-compatible Doom engine based on PrBoom
chaotic-aur/prboom-plus-um-git 2.6.66.r0.g96951516-1
    An advanced, Vanilla-compatible Doom engine based on PrBoom. Includes support for UMAPINFO
fabiangreffrath commented 1 year ago

Why does this have two packages? The 2.6.66 tag has been applied to the 96951516 git commit and the repository has been closed since then. There are no further commits and the contents of both packages are identical.

xiota commented 1 year ago

@fabiangreffrath No idea. Looking for old issues that can be closed. Can you test whether dsda-doom and dsda-doom-git have the same issue? If one of them doesn't, would there be any reason to keep prboom-plus*, since dsda-doom is a fork?

fabiangreffrath commented 1 year ago

Well, dsda-coom is in active development, so there is actually a difference between releases and git snapshots. prboom-plus is dead and won't be maintained any further. I have already replaced it with dsda-doom in Debian.

xiota commented 1 year ago

prboom-plus is dead and won't be maintained any further. I have already replaced it with dsda-doom in Debian.

So it would be okay to drop prboom-plus* and close this issue?

fabiangreffrath commented 1 year ago

The release might still be relevant to some, but the git snapshot can be dropped.

xiota commented 1 year ago

Since development on prboom-plus has ceased, this issue will most likely never be resolved. So closing this as not planned.

prboom-plus-um-git has been dropped, since it's essentially a duplicate of prboom-plus, which will be kept for now.