[Bug] hplip setup requires to install hplip-plugin manually

AriaMoradi commented 1 year ago

What happens?

Including hplip-plugin in chaotic-aur repo makes the package to install directly via pacman.

During execution of the hp-setup utility for my printer (and probably other printers that require the plugin) the setup utility asks for path to hplip-x.y.z.-plugin.run which is the source file for the package. The setup wizard utility seems to ignore the fact that the plugin is installed by the user and require it no matter what.

Not installing it manually or via an aur helper prevents users to have access to that file.

I suggest removing hplip-plugin from chaotic aur.

What is expected to happen?

N/A

If possible, please attach logs

$ hp-setup -i 192.168.1.120 -a              

HP Linux Imaging and Printing System (ver. 3.23.3)
Printer/Fax Setup Utility ver. 9.0

Copyright (c) 2001-18 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

(Note: Defaults for each question are maked with a '*'. Press <enter> to accept the default.)

Setting up device: hp:/net/HP_LaserJet_Pro_MFP_M127fw?ip=192.168.1.120

-------------------
| UPDATING PLUGIN |
-------------------

HP Linux Imaging and Printing System (ver. 3.23.3)
Plugin Download and Install Utility ver. 2.1

Copyright (c) 2001-18 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

HP Linux Imaging and Printing System (ver. 3.23.3)
Plugin Download and Install Utility ver. 2.1

Copyright (c) 2001-18 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

(Note: Defaults for each question are maked with a '*'. Press <enter> to accept the default.)

-----------------------------------------
| PLUG-IN INSTALLATION FOR HPLIP 3.23.3 |
-----------------------------------------

  Option      Description                                       
  ----------  --------------------------------------------------
  d           Download plug-in from HP (recommended)            
  p           Specify a path to the plug-in (advanced)          
  q           Quit hp-plugin (skip installation)                

Enter option (d=download*, p=specify path, q=quit) ? /home/armor/.cache/yay/hplip-plugin/hplip-3.23.3-plugin.run
error: Please enter 'd', 'p', 'q' or press <enter> for the default of 'd'.

Enter option (d=download*, p=specify path, q=quit) ? p
Enter the path to the 'hplip-3.23.3-plugin.run' file (q=quit) : /home/armor/.cache/yay/hplip-plugin/hplip-3.23.3-plugin.run

---------------
| COPY PLUGIN |
---------------

Downloading plug-in from: file:///home/armor/.cache/yay/hplip-plugin/hplip-3.23.3-plugin.run
Downloading plug-in: [\                                                  ] 0%  100%error: Failed to open URL: file:///home/armor/.cache/yay/hplip-plugin/hplip-3.23.3-plugin.run.asc
error: Plug-in GPG file [file:///home/armor/.cache/yay/hplip-plugin/hplip-3.23.3-plugin.run.asc] download failed.

error: Failed to download /home/armor/.hplip/hplip-3.23.3-plugin.run.asc
Do you still want to install the plug-in? (y=yes, n=no*, q=quit) ? yes
error: Please press <enter> or enter 'y', 'n', or 'q'.
Do you still want to install the plug-in? (y=yes, n=no*, q=quit) ? y

----------------------
| INSTALLING PLUG-IN |
----------------------

Creating directory plugin_tmp
Verifying archive integrity...  100%   All good.
Uncompressing HPLIP 3.23.3 Plugin Self Extracting Archive  100%  

HP Linux Imaging and Printing System (ver. 3.23.3)
Plugin Installer ver. 3.0

Copyright (c) 2001-18 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

Plug-in version: 3.23.3
Installed HPLIP version: 3.23.3
Number of files to install: 64

You must agree to the license terms before installing the plug-in:

LICENSE TERMS FOR HP Linux Imaging and Printing (HPLIP) Driver Plug-in                                                                                                                         

These License Terms govern your Use of the HPLIP Driver Plug-in Software (the "Software"). USE OF THE SOFTWARE INCLUDING, WITHOUT LIMITATION, ANY DOCUMENTATION, IS SUBJECT TO THESE LICENSE   
TERMS AND THE APPLICABLE AS-IS WARRANTY STATEMENT. BY DOWNLOADING AND INSTALLING THE SOFTWARE, YOU ARE AGREEING TO BE BOUND BY THESE TERMS. IF YOU DO NOT AGREE TO ALL OF THESE TERMS, DO NOT  
DOWNLOAD AND INSTALL THE SOFTWARE ON YOUR SYSTEM.                                                                                                                                              

1. License Grant. HP grants you a license to Use one copy of the Software with HP printing products only. "Use" includes using, storing, loading, installing, executing, and displaying the    
Software. You may not modify the Software or disable any licensing or control features of the Software.                                                                                        

2. Ownership. The Software is owned and copyrighted by HP or its third party suppliers. Your license confers no title to, or ownership in, the Software and is not a sale of any rights in the 
Software. HP's third party suppliers may protect their rights in the Software in the event of any violation of these license terms.                                                            

3. Copies and Adaptations. You may only make copies or adaptations of the Software for archival purposes or when copying or adaptation is an essential step in the authorized Use of the       
Software. You must reproduce all copyright notices in the original Software on all copies or adaptations. You may not copy the Software onto any public network.                               

4. No Disassembly. You may not Disassemble the Software unless HP's prior written consent is obtained. "Disassemble" includes disassembling, decompiling, decrypting, and reverse engineering. 
In some jurisdictions, HP's consent may not be required for limited Disassembly. Upon request, you will provide HP with reasonably detailed information regarding any Disassembly.             

5. No Transfer. You may not assign, sublicense or otherwise transfer all or any part of these License Terms or the Software.                                                                   

6. Termination. HP may terminate your license, upon notice, for failure to comply with any of these License Terms. Upon termination, you must immediately destroy the Software, together with  
all copies, adaptations and merged portions in any form.                                                                                                                                       

7. Export Requirements. You may not export or re-export the Software or any copy or adaptation in violation of any applicable laws or regulations.                                             

8. U.S. Government Restricted Rights. The Software has been developed entirely at private expense. It is delivered and licensed, as defined in any applicable DFARS, FARS, or other equivalent 
federal agency regulation or contract clause, as either "commercial computer software" or "restricted computer software", whichever is applicable. You have only those rights provided for such
Software by the applicable clause or regulation or by these License Terms.                                                                                                                     

9. DISCLAIMER OF WARRANTIES. TO THE MAXIMUM EXTENT PERMITTED BY APPLICABLE LAW, HP AND ITS SUPPLIERS PROVIDE THE SOFTWARE "AS IS" AND WITH ALL FAULTS, AND HEREBY DISCLAIM ALL OTHER WARRANTIES
AND CONDITIONS, EITHER EXPRESS, IMPLIED, OR STATUTORY, INCLUDING, BUT NOT LIMITED TO, WARRANTIES OF TITLE AND NON-INFRINGEMENT, ANY IMPLIED WARRANTIES, DUTIES OR CONDITIONS OF                
MERCHANTABILITY, OF FITNESS FOR A PARTICULAR PURPOSE, AND OF LACK OF VIRUSES ALL WITH REGARD TO THE SOFTWARE. Some states/jurisdictions do not allow exclusion of implied warranties or        
limitations on the duration of implied warranties, so the above disclaimer may not apply to you in its entirety.                                                                               

10. LIMITATION OF LIABILITY. Notwithstanding any damages that you might incur, the entire liability of HP and any of its suppliers under any provision of this agreement and your exclusive    
remedy for all of the foregoing shall be limited to the greater of the amount actually paid by you separately for the Software or U.S. $5.00. TO THE MAXIMUM EXTENT PERMITTED BY APPLICABLE    
LAW, IN NO EVENT SHALL HP OR ITS SUPPLIERS BE LIABLE FOR ANY SPECIAL, INCIDENTAL,                                                                                                              
INDIRECT, OR CONSEQUENTIAL DAMAGES WHATSOEVER (INCLUDING, BUT NOT LIMITED TO, DAMAGES FOR LOSS OF PROFITS OR CONFIDENTIAL OR OTHER INFORMATION, FOR BUSINESS INTERRUPTION, FOR PERSONAL INJURY,
FOR LOSS OF PRIVACY ARISING OUT OF OR IN ANY WAY RELATED TO THE USE OF OR INABILITY TO USE THE SOFTWARE, OR OTHERWISE IN CONNECTION WITH ANY PROVISION OF THIS AGREEMENT, EVEN IF HP OR ANY    
SUPPLIER HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES AND EVEN IF THE REMEDY FAILS OF ITS ESSENTIAL PURPOSE. Some states/jurisdictions do not allow the exclusion or limitation of      
incidental or consequential damages, so the above limitation or exclusion may not apply to you.                                                                                                

Do you accept the license terms for the plug-in (y=yes*, n=no, q=quit) ? y
Please enter the sudoer (armor)'s password: 

Done.

Done.

---------------------
| PRINT QUEUE SETUP |
---------------------

Please enter a name for this print queue (m=use model name:'HP_LaserJet_Pro_MFP_M127fw'*, q=quit) ?
Using queue name: HP_LaserJet_Pro_MFP_M127fw
Locating PPD file... Please wait.

Found PPD file: drv:///hp/hpcups.drv/hp-laserjet_pro_mfp_m127fw.ppd
Description: 

Note: The model number may vary slightly from the actual model number on the device.

Does this PPD file appear to be the correct one (y=yes*, n=no, q=quit) ? 
Enter a location description for this printer (q=quit) ?
Enter additonal information or notes for this printer (q=quit) ?

Adding print queue to CUPS:
Device URI: hp:/net/HP_LaserJet_Pro_MFP_M127fw?ip=192.168.1.120
Queue name: HP_LaserJet_Pro_MFP_M127fw
PPD file: drv:///hp/hpcups.drv/hp-laserjet_pro_mfp_m127fw.ppd
Location: 
Information: 

-------------------
| FAX QUEUE SETUP |
-------------------

Please enter a name for this fax queue (m=use model name:'HP_LaserJet_Pro_MFP_M127fw_fax'*, q=quit) ?
Using queue name: HP_LaserJet_Pro_MFP_M127fw_fax
Enter a location description for this printer (q=quit) ?
Enter additonal information or notes for this printer (q=quit) ?

Adding fax queue to CUPS:
Device URI: hpfax:/net/HP_LaserJet_Pro_MFP_M127fw?ip=192.168.1.120
Queue name: HP_LaserJet_Pro_MFP_M127fw_fax
PPD file: /usr/share/ppd/HP/HP-Fax2-hpcups.ppd.gz
Location: 
Information: 

--------------------
| FAX HEADER SETUP |
--------------------

Would you like to perform fax header setup (y=yes*, n=no, q=quit) ?

Enter the fax phone number for this device (c=use current:'<REDACTED>'*, q=quit) ?

Enter the name and/or company for this device (c=use current:'HPFAX'*, q=quit) ?

Parameters sent to device.

---------------------
| PRINTER TEST PAGE |
---------------------

Would you like to print a test page (y=yes*, n=no, q=quit) ? 

HP Linux Imaging and Printing System (ver. 3.23.3)
Testpage Print Utility ver. 6.0

Copyright (c) 2001-18 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

HP Linux Imaging and Printing System (ver. 3.23.3)
System Tray Status Service ver. 2.0

Copyright (c) 2001-18 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

warning: GUI Modules PyQt4 and PyQt5 are not installed
error: hp-systray requires Qt4 GUI and DBus support. Exiting.
warning: Unable to connect to dbus. Is hp-systray running?
Printing test page to printer HP_LaserJet_Pro_MFP_M127fw...
Test page has been sent to printer.

note: If an error occured, or the test page failed to print, refer to the HPLIP website
note: at: http://hplip.sourceforge.net for troubleshooting and support.

Done.

Done.

More information

No response

Technetium1 commented 1 year ago

@PedroHLC it was yours

PedroHLC commented 1 year ago

I don't get why hp changed the hplip behavior, but hplip-plugin still install the PPD files that can be used to install the printer manually via CUPS web inter or KDE's printer configuration.

My suggestion is: keep hplip-plugin and ban hplip from repo.

PS: CUPS matches the KISS Arch-way, KDE is thousands of times less buggy than this hplip wizard.

AriaMoradi commented 1 year ago

I don't get why hp changed the hplip behavior

Nothing has changed, it has been working like this since at least 2020-21

PedroHLC commented 1 year ago

I don't get why hp changed the hplip behavior

Nothing has changed, it has been working like this since at least 2020-21

Last I used it, it was still able to use the final files from the hplip-plugin. Around 2018-19, I found out about KDE's printer configuration and never looked back. Nowadays, http://127.0.0.1:631/admin/ seems to do everything I need, including using the files from hplip-plugin...

Technetium1 commented 5 months ago

hplip (which is now extra) depends on python-pyqt5 so it would not be added when it eventually comes back into the AUR, due to Qt5 removal in #3157.

chaotic-aur / packages