search

chaotic-aur / packages

The packages Mason, what do they mean? (Package requests and bug reports here) 📑
https://aur.chaotic.cx
326 stars 20 forks source link

[Bug] armcord-git package bugged #2702

Closed D3vil0p3r closed 3 months ago

D3vil0p3r commented 1 year ago

Packages:

armcord-git

Latest chaotic version

r943.8e43e5a-1

What happens?

When I use ArmCord installed by Chaotic, the screenshare does not work properly, for example I don't get either the chance to choice the entire screen.

When I compile ArmCord from source (same latest commit), it works. I discussed this with ArmCord dev and maybe the Chaotic package should be rebuilt from source. Reference: https://github.com/ArmCord/ArmCord/issues/305#issuecomment-1666519706

What is expected to happen?

Screenshare Full Screen working as the compiled from source version.

Logs

No response

More information

No response

Technetium1 commented 1 year ago

@D3vil0p3r please try it again. Unfortunately, I was unable to get a bump to work, but it's been rebuilt.

dr460nf1r3 commented 1 year ago

@D3vil0p3r please try it again. Unfortunately, I was unable to get a bump to work, but it's been rebuilt.

-git packages ignore bumps due to setting their own pkgver at build time.

D3vil0p3r commented 1 year ago

@D3vil0p3r please try it again. Unfortunately, I was unable to get a bump to work, but it's been rebuilt.

-git packages ignore bumps due to setting their own pkgver at build time.

I know but I'm getting a diifferent behavior between the latest package retrieved by Chaotic AUR of armcord-git related to the latest commit and the one built and compiled from source (despite they should be the same). The different behavior is on the screen share:

When the user is inside a vocal chat and run a screenshare:

Despite both of the versions are built on the same commit, so I guess that the AUR package is built bad (?)

xiota commented 1 year ago

@D3vil0p3r Could be a missing make depend. Are you building in clean chroot?

D3vil0p3r commented 1 year ago

@D3vil0p3r Could be a missing make depend. Are you building in clean chroot?

Yes, I built in clean chroot by using source files. So I guess that the PKGBUILD of AUR package is built in a wrong manner.

The GitHub repo says to build in the this manner, but the armcord-git PKGBUILD builds the package in a different manner. I guess it could be the issue.

Technetium1 commented 1 year ago

That should be fine still as it has the same effect: https://github.com/ArmCord/ArmCord/blob/8a79d3402d6b6f05fa1077b27d66d2faaa22c9c1/package.json#L17C67-L17C67

D3vil0p3r commented 1 year ago

Do you mean that the reason is not that PKGBUILD uses different commands than the ones shown in the original GitHub repo?

Technetium1 commented 1 year ago

Yes, it's installing the same deps. If it didn't, then it shouldn't be able to compile successfully at all 😖

D3vil0p3r commented 1 year ago

I can try to test that PKGBUILD but by using the build commands reported in the original project page.

xiota commented 1 year ago

I don't know enough about this package to try to fix, but different behavior is often caused by using or building with different packages. Scripted languages often have their own package managers, virtual environment, etc that can use different versions of packages than the system has available.

Technetium1 commented 1 year ago

It is explicitly using the same lockfile and not updating 👀 https://classic.yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-frozen-lockfile

Don’t generate a yarn.lock lockfile and fail if an update is needed. If you need reproducible dependencies, which is usually the case with the continuous integration systems, you should pass --frozen-lockfile flag.

Maybe this is a sign of a missed transitive dependency being added, causing the lock to be updated even when it shouldn't. Could test with and without freezing lockfile.

D3vil0p3r commented 1 year ago

Thank you guys. I will test directly the PKGBUILD in clean chroot with and without --frozen-lockfile.

D3vil0p3r commented 1 year ago

According to my tests, the source of the issue in the armcord-git is app.asar. The PKGBUILD leverages on the file armcord-launcher.sh that calls /usr/share/armcord/app.asar by electron /usr/share/armcord/app.asar. This file generates that two popup windows.

The original building (also performed by the PKGBUILD) generates not only app.asar but also a binary file $pkgdir/dist/linux-unpacked/armcord that is the one where we don't get this issue.

FYI: https://github.com/ArmCord/ArmCord/issues/305

Vendicated commented 3 months ago

this has nothing to do with the package. the armcord binary is nothing else except renamed electron. that's how electron apps function. the multiple screenshare popups are caused by the interaction of chromium and your desktop environment. it's on your end

xiota commented 3 months ago

This package is currently not working. The problem appears to be upstream (not the AUR package). I am dropping this package because broken builds provide users with no benefit.

D3vil0p3r commented 3 months ago

@xiota should we package armcord or armcord-bin?

xiota commented 3 months ago

armcord-bin was previously rejected – #2978

aur/armcord currently fails to build.

xiota commented 1 month ago

@D3vil0p3r Please test chaotic-aur/armcord. If it works without problems and you're still interested in it, you may open a new request to add it.