search

chaotic-aur / packages

The packages Mason, what do they mean? (Package requests and bug reports here) 📑
https://aur.chaotic.cx
326 stars 20 forks source link

[Request] gnome-shell-extension-material-shell #2728

Closed D3vil0p3r closed 1 year ago

D3vil0p3r commented 1 year ago

Package:

gnome-shell-extension-material-shell

Purpose:

Modern desktop interface for GNOME Shell

non-git version. git version is already packaged: https://github.com/chaotic-aur/packages/issues/463

Benefits:

Improve your user experience and get rid of the anarchy of traditional desktop workflows. Designed to simplify navigation and reduce the need to manipulate windows in order to improve productivity. It's meant to be 100% predictable and bring the benefits of tools coveted by professionals to everyone.

Building:

No response

Copyright:

GPL3

Expected Interest:

Many

Already available?

No

Unique request?

Yes

Banned package?

No

More information:

No response

Technetium1 commented 1 year ago

Build fails: gnome-shell-extension-material-shell.log

D3vil0p3r commented 1 year ago

I'm not getting any error during the build.

Technetium1 commented 1 year ago

@D3vil0p3r is it in clean chroot by chance? Take a look at the incorrect path in my above link.

D3vil0p3r commented 1 year ago

@D3vil0p3r is it in clean chroot by chance? Take a look at the incorrect path in my above link.

Yes, in clean chroot:

==> Extracting sources...
  -> Extracting gnome-shell-extension-material-shell-44.tar.gz with bsdtar
==> Starting build()...

added 222 packages, and audited 223 packages in 8s

30 packages are looking for funding
  run `npm fund` for details

2 moderate severity vulnerabilities

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
npm notice 
npm notice New major version of npm available! 9.8.1 -> 10.0.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0>
npm notice Run `npm install -g npm@10.0.0` to update!
npm notice 
rm -rf dist
mkdir dist
cp -r schemas dist
glib-compile-schemas dist/schemas/
npx sass --no-source-map src/styles/dark-theme.scss dist/style-dark-theme.css
npm notice 
npm notice New major version of npm available! 9.8.1 -> 10.0.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0>
npm notice Run `npm install -g npm@10.0.0` to update!
npm notice 
npx sass --no-source-map src/styles/light-theme.scss dist/style-light-theme.css
npx sass --no-source-map src/styles/primary-theme.scss dist/style-primary-theme.css
make: git: No such file or directory
npx tsc
npx tsc scripts/transpile.ts --outDir build && node build/transpile.js
npm run rollup-extension && npm run rollup-prefs

> material-shell@1.0.0 rollup-extension
> npx rollup -c rollup.config.js -i build/extension.js  -o dist/extension.js

build/extension.js → dist/extension.js...
created dist/extension.js in 661ms

> material-shell@1.0.0 rollup-prefs
> npx rollup -c rollup.config.prefs.js -i build/prefs/prefs.js  -o dist/prefs.js

/build/gnome-shell-extension-material-shell/src/material-shell-44/build

build/prefs/prefs.js → dist/prefs.js...
created dist/prefs.js in 120ms
sed "s/{put_commit_there}//" metadata.json > dist/metadata.json
cp -r assets dist/assets
==> Entering fakeroot environment...
==> Starting package()...
==> Tidying install...
  -> Removing libtool files...
  -> Purging unwanted files...
  -> Removing static library files...
  -> Stripping unneeded symbols from binaries and libraries...
  -> Compressing man and info pages...
==> Checking for packaging issues...
==> Creating package "gnome-shell-extension-material-shell"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
==> Leaving fakeroot environment.
==> Finished making: gnome-shell-extension-material-shell 44-1 (Mon Sep  4 22:19:50 2023)
Technetium1 commented 1 year ago

New problem:

Downloading: gnome-shell-extension-material-shell
Trying to make directory...
Finished preparing gnome-shell-extension-material-shell.
Starting making gnome-shell-extension-material-shell at Tue Sep  5 02:48:53 CEST 2023
Building package "gnome-shell-extension-material-shell"
execv(/home/main-builder/wizard.sh) failed: No such file or directory
D3vil0p3r commented 1 year ago

Why am I not getting that issue in clean chroot?

dr460nf1r3 commented 1 year ago

This was related to a not created lowerdir, it's fixed now though.

Technetium1 commented 1 year ago

It gets hung up here: https://github.com/material-shell/material-shell/blob/89f460b3717a541082f5b87b514f7cc23e3ea170/Makefile#L23

D3vil0p3r commented 1 year ago

It gets hung up here: https://github.com/material-shell/material-shell/blob/89f460b3717a541082f5b87b514f7cc23e3ea170/Makefile#L23

We need to open a PR or Issue on their side?

Technetium1 commented 1 year ago

Maybe pkgbuild issue... @xiota thoughts? https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gnome-shell-extension-material-shell https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gnome-shell-extension-material-shell-git

xiota commented 1 year ago

Thought: Banish npm packages.

Nothing stands out to me in the PKGBUILD. I have the same error building in clean chroot locally. Looks like instructions are being run out of order.

In Makefile, lines 22-23:

rm -rf dist
mkdir dist

And lines 7-8:

cp -r schemas dist
glib-compile-schemas dist/schemas/

But from the log, it looks like it's running 22, 7, 23, 8, ...

rm -rf dist
cp -r schemas dist
mkdir dist
glib-compile-schemas dist/schemas/
mkdir: cannot create directory ‘dist’: File exists
make: *** [Makefile:23: dist] Error 1
make: *** Waiting for unfinished jobs....
Error opening directory “dist/schemas/”: No such file or directory
make: *** [Makefile:8: schemas] Error 1

Potential solution: Disable whatever enables out of order execution? (No idea what that is though.)

xiota commented 1 year ago

Adding export MAKEFLAGS='-j1' to build() allows this to build. Is this package worth adding an interfere?

dr460nf1r3 commented 1 year ago

If it allows building, definitely 👀

xiota commented 1 year ago

Putting export MAKEFLAGS=... in prepare script doesn't work. Has to be in build().

gnome-shell-extension-material-shell-git has same problem.

Both working now.