chaotic-aur / packages

The packages Mason, what do they mean? (Package requests and bug reports here) 📑
https://aur.chaotic.cx
331 stars 20 forks source link

[Request] vcmi #2763

Open slepice24 opened 1 year ago

slepice24 commented 1 year ago

Package:

vcmi - https://aur.archlinux.org/packages/vcmi Manual Installation - https://wiki.vcmi.eu/How_to_build_VCMI_(Linux)

Purpose:

recreation of heroes III engine that brings new features

Benefits:

No response

Building:

optional dependencies are required for vcmibuilder (at least unshield)

Copyright:

VCMI source code is licensed under GPL2, vcmi-assets - https://github.com/vcmi/vcmi-assets

Expected Interest:

some

Already available?

no

Unique request?

yes

Banned package?

no

More information:

No response

xiota commented 1 year ago

Suppose vcmi and vcmi-assets are both made available. Will the game work? Or is access to the original game still somehow required?

slepice24 commented 1 year ago

Suppose vcmi and vcmi-assets are both made available. Will the game work? Or is access to the original game still somehow required?

you need the original game files to play

xiota commented 1 year ago

you need the original game files to play

If it's not at all usable without proprietary data, I'm inclined against adding, but another maintainer may have a different opinion.

slepice24 commented 1 year ago

you need the original game files to play

sorry i wast detail, for installation and runing vcmi you dont need heroes III but for playing you need it, sorry any confusion made

xiota commented 1 year ago

Why would anyone run it if it can't be played?

slepice24 commented 1 year ago

Why would anyone run it if it can't be played?

importing game files

Technetium1 commented 1 year ago

I'm happy we can provide resources when necessary, sometimes it's painful to build and/or download some sources for various reasons. The only issue we can have is when the lack of one of those 'proprietary files' prevents building. That's the issue we have with ezquake, which we would otherwise be fine to redistribute. If it builds without needing extra files, and the size is reasonable, then it's okay. In this case, everything comes from GitHub & the Arch repos except fuzzylite.

I tried to build it to see the size, and it's at least >100MB. It also doesn't build in a clean chroot due to missing dependencies. Due to the size and build failure in a clean chroot, this request is unfortunately rejected.

If you'd like to report this not building in a clean chroot to the maintainer, so it can be fixed, it would help others. One clear problem is minizip missing in makedepends.

Failed Build Log ``` -- Checking for module 'minizip' -- Package 'minizip', required by 'virtual:world', not found -- Could NOT find minizip (missing: minizip_LIBRARY minizip_INCLUDE_DIR) -- Found SDL2: /usr/lib/libSDL2.so (found version "2.28.3") CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to `find_package_handle_standard_args` (SDL2main) does not match the name of the calling package (SDL2). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake_modules/FindSDL2.cmake:318 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:410 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. -- Found SDL2main: /usr/lib/libSDL2main.a (found version "2.28.3") CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to `find_package_handle_standard_args` (SDL2main) does not match the name of the calling package (SDL2). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake_modules/FindSDL2.cmake:318 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) cmake_modules/FindSDL2_image.cmake:114 (find_package) CMakeLists.txt:411 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. -- Found SDL2_image: /usr/lib/libSDL2_image.so (found version "2.6.3") CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to `find_package_handle_standard_args` (SDL2main) does not match the name of the calling package (SDL2). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake_modules/FindSDL2.cmake:318 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) cmake_modules/FindSDL2_mixer.cmake:112 (find_package) CMakeLists.txt:415 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. -- Found SDL2_mixer: /usr/lib/libSDL2_mixer.so (found version "2.6.3") CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to `find_package_handle_standard_args` (SDL2main) does not match the name of the calling package (SDL2). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake_modules/FindSDL2.cmake:318 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) cmake_modules/FindSDL2_ttf.cmake:114 (find_package) CMakeLists.txt:419 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. -- Found SDL2_ttf: /usr/lib/libSDL2_ttf.so (found version "2.20.2") CMake Error at /usr/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package): Could not find a package configuration file provided by "Qt5LinguistTools" with any of the following names: Qt5LinguistToolsConfig.cmake qt5linguisttools-config.cmake Add the installation prefix of "Qt5LinguistTools" to CMAKE_PREFIX_PATH or set "Qt5LinguistTools_DIR" to a directory containing one of the above files. If "Qt5LinguistTools" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): CMakeLists.txt:430 (find_package) -- Configuring incomplete, errors occurred! ==> ERROR: A failure occurred in build(). Aborting... ```
xiota commented 3 months ago

Reopening for re-review because someone requested in chat.

Looks like maintainer is active. PKGBUILD could be improved, but don't think they're showstoppers (mkdir, ccache). So if size is okay and it builds/works (or maintainer fixes issues), I'd have no problem with adding it.