chaotic-aur / packages

Read-only mirror of Chaotic-AUR's main repository. Issues and bug reports welcome! 📑
https://gitlab.com/chaotic-aur/pkgbuilds
GNU General Public License v3.0
338 stars 20 forks source link

[Request] firefox-globalmenu #3362

Closed leap0x7b closed 2 weeks ago

leap0x7b commented 1 month ago

Package:

https://aur.archlinux.org/pkgbase/firefox-globalmenu

Purpose:

A version of Firefox that supports Mac-like global menus

Benefits:

Firefox by default doesn't support global menus. This package resolves that issue and makes Firefox look more native on desktop environments with support for global menus such as KDE.

Building:

No response

Copyright:

MPL-2.0

Expected Interest:

Some

Already available?

No

Unique request?

Yes

Banned package?

No

More information:

No response

dr460nf1r3 commented 1 month ago

Didn't we have already firefox-appmenu.. which is entirely the same Firefox using the same patches from what I've seen?

leap0x7b commented 1 month ago

image

Technetium1 commented 1 month ago

@dr460nf1r3 👀 https://github.com/chaotic-aur/packages/commit/06083a425dae1427a1b57250d42f05f8392467df Was this supposed to be the replacement?

xiota commented 1 month ago

Inclined to reject. I don't want to deal with yet another fork.

The appmenu patch is no longer maintained by the original developer (Ubuntu), so the package maintainer has to keep it updated. The patch is prone to breaking, and there is no real need to use the menubar on a regular basis.

Also, firefox-globalmenu does not build with PGO, so would have ~20% worse performance than extra/firefox.

xiota commented 1 month ago

Was this supposed to be the replacement?

-globalmenu is replacement for -appmenu. The appmenu version had some maintenance issues, and some people didn't realize that appmenu = global menu = dbus menu.

xiota commented 2 weeks ago

Rejecting for aforementioned reasons.