chaotic-aur / toolbox

Unified kit with all the scripts required for maintaining the repository 🧰
https://aur.chaotic.cx
GNU Affero General Public License v3.0
81 stars 11 forks source link

clean-duplicates: escape '+' in filenames #104

Closed xiota closed 4 months ago

xiota commented 7 months ago

chaotic dedup misses filenames containing + because it's a special symbol in grep (Perl/Extended) regular expressions. find seems to work with escaped or unescaped +.

xiota commented 6 months ago

@PedroHLC Have you had a chance to look at this?

To see the problem this is intended to solve, run chaotic dedup, then:

$ repoctl status
On repo chaotic-aur

    c++utilities: obsolete(1)

Affected packages:

$ pacman -Ss '\+' | sed 's& .*$&&' | grep '+' | grep '^chaotic-aur'
chaotic-aur/c++utilities
chaotic-aur/foobillard++
chaotic-aur/libstdc++5
chaotic-aur/speedtest++
PedroHLC commented 6 months ago

@PedroHLC Have you had a chance to look at this?

I did, the thing is that I didn't like when I wrote the original pipe there, so I set myself to rewrite it later, but completely forgot about it, and now I'm considering rewriting it :sweat_smile: but still haven't got the chance.

xiota commented 4 months ago

Would it be okay to merge while future changes are pending?

(Alternatively, drop and ban any package with a + in its name.)

dr460nf1r3 commented 4 months ago

Deployed to all builders 🧙

xiota commented 4 months ago

Thank you.