chaotic-cx / nyx

Nix flake for "too much bleeding-edge" and unreleased packages (e.g., mesa_git, linux_cachyos, firefox_nightly, sway_git, gamescope_git). And experimental modules (e.g., HDR, duckdns).
https://nyx.chaotic.cx
MIT License
309 stars 34 forks source link

[Request] Instead of setting linux_cachyos, assert AMD_PRIVATE_COLOR for HDR #630

Closed PedroHLC closed 3 months ago

PedroHLC commented 5 months ago

What happens?

Presently, chaotic.hdr sets kernel to linux_cachyos. But HDR has been merged into Linux 6.8, so this is not needed anymore. Instead, we want any 6.8+ kernel built with -DAMD_PRIVATE_COLOR in KCFLAGS.

What is expected to happen?

If the user has an LTS kernel, he should be warned that it does not support HDR, and advised to upgrade to either 6.8+ with AMD_PRIVATE_COLOR or linux_cachyos (needs rebuild with AMD_PRIVATE_COLOR rn).

SuperSamus commented 5 months ago

I may be wrong, but doesn't Linux 6.8 require AMD_PRIVATE_COLOR for HDR to function? (https://github.com/ValveSoftware/gamescope/pull/1149)

PedroHLC commented 5 months ago

I may be wrong, but doesn't Linux 6.8 require AMD_PRIVATE_COLOR for HDR to function?

In this case, I wonder if I can assert that config instead. Providing both gamescope (with and without patch) should be easy.

PedroHLC commented 5 months ago

UPDATE: I've added the patches to gamescope_git, and AMD_PRIVATE_COLOR to the kernels: and it works, gamesocpe puts it in HDR and shows the color properly.

But, right now, gamescope_git is producing an 80% corrupt output on my end.

(No changes were done to the options)

SuperSamus commented 5 months ago

gamescope_git is producing an 80% corrupt output on my end

Known issue: https://github.com/ValveSoftware/gamescope/issues/1191 Staying on commit 14a1db3a should fix it.