chaotic-society / theoretica

A C++ math library for scientific computing with a simple and elegant interface.
https://chaotic-society.github.io/theoretica/
GNU Lesser General Public License v3.0
21 stars 4 forks source link

Add comprehensive test cases for bitwise operations in bit_op.h #88

Closed Fahad-Ali-Khan-ca closed 1 month ago

Fahad-Ali-Khan-ca commented 1 month ago

Description

Hello! I’ve added test cases for the bitwise operations in bit_op.h to ensure they function correctly and match expected results. This pull request is intended as a preliminary submission to confirm that my approach aligns with the testing standards for this repository.

I plan to continue writing test cases for the core module as well all the other modules, so I would appreciate any feedback you may have on these initial tests. This will help me make improvements before proceeding with further contributions.

Thank you for reviewing my work!

mattiaisgro commented 1 month ago

That's awesome, you're doing great! I'm merging the pull request right-away.

mattiaisgro commented 1 month ago

I plan to continue writing test cases for the core module as well all the other modules, so I would appreciate any feedback you may have on these initial tests. This will help me make improvements before proceeding with further contributions.

Thank you for reviewing my work!

Your code is great, any suggestions would be more stylistic than anything! I have made a commit https://github.com/chaotic-society/theoretica/commit/eaa4e17afccdb199a19d1fe6ac093b559374e1e0 where you can see a few things that I have changed, but they are minor changes. Some test cases had long names so I increased the column width:

output::settings.fieldOptions["name"].columnWidth = 24;

I added a few empty cases which are useful sanity checks. I also noticed that you use spaces, for this project we usually use tabs!

Fahad-Ali-Khan-ca commented 1 month ago

Thank you for reviewing my work!

I'll keep the coding standards in mind and ensure consistency going forward. I'll review the changes in commit eaa4e17 and incorporate these adjustments into my future contributions. I appreciate your guidance, and I’m looking forward to making further improvements!