Using a non-param value in an enum can cause an internal error

[jabraham17]

Summary of Problem

Using a non-param value as the initializer for an enum value is an error, but doing so with a more complicated expression is not checked and results in an internal error.

Steps to Reproduce

Source Code:

proc foo() /*param*/ do return 1;
enum A {
  a=foo()+1, // without the +1, correctly gives user an error that expression is not a param value
}

Compile command: chpl test.chpl

Output

test.chpl:2: internal error: RES-CAL-NFO-0090 chpl version 1.31.0 pre-release (2048f5ab31)
Note: This source location is a guess.

Internal errors indicate a bug in the Chapel compiler,
and we're sorry for the hassle.  We would appreciate your reporting this bug --
please see https://chapel-lang.org/bugs.html for instructions.  In the meantime,
the filename + line number above may be useful in working around the issue.

Configuration Information

• Output of chpl --version:

  chpl version 1.31.0 pre-release (2048f5ab31)
  built with LLVM version 14.0.6
  available LLVM targets: amdgcn, r600, nvptx64, nvptx, aarch64_32, aarch64_be, aarch64, arm64_32, arm64, x86-64, x86
  Copyright 2020-2023 Hewlett Packard Enterprise Development LP
  Copyright 2004-2019 Cray Inc.
  (See LICENSE file for more details)

• Output of $CHPL_HOME/util/printchplenv --anonymize:

  CHPL_TARGET_PLATFORM: darwin
  CHPL_TARGET_COMPILER: llvm
  CHPL_TARGET_ARCH: arm64
  CHPL_TARGET_CPU: native *
  CHPL_LOCALE_MODEL: flat
  CHPL_COMM: none
  CHPL_TASKS: fifo
  CHPL_LAUNCHER: none
  CHPL_TIMERS: generic
  CHPL_UNWIND: none
  CHPL_MEM: cstdlib
  CHPL_ATOMICS: cstdlib
  CHPL_GMP: bundled
  CHPL_HWLOC: none
  CHPL_RE2: bundled
  CHPL_LLVM: bundled *
  CHPL_AUX_FILESYS: none

• Back-end compiler and version, e.g. gcc --version or clang --version:

  Apple clang version 13.1.6 (clang-1316.0.21.2.5)
  Target: arm64-apple-darwin21.4.0
  Thread model: posix
  InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

[DanilaFe]

The issue here is that we skip normalizing the definitions of enum constant values. I tried performing normalization, but this does not seem to go well (though, I may have just not tried hard enough! 😄 ). Another thought was to try skipping the assertion for normalization if defining an EnumSymbol, but that seemed like a needless special case.