search

chapel-lang / chapel

a Productive Parallel Programming Language
https://chapel-lang.org
Other
1.75k stars 410 forks source link

Patch bundled gasnet to pull in bugfix for IBV #24899

Closed jabraham17 closed 3 weeks ago

jabraham17 commented 3 weeks ago

This PR patches the bundled gasnet to pull in a fix for gasnet using the ibv-conduit with clang16+.

Gasnet bug: https://gasnet-bugs.lbl.gov/bugzilla/show_bug.cgi?id=4617 Gasnet patch: https://bitbucket.org/berkeleylab/gasnet/pull-requests/625

Resolves https://github.com/chapel-lang/chapel/issues/24779 Resolves https://github.com/chapel-lang/chapel/issues/22055

Tested by building with CHPL_COMM=gasnet and CHPL_COMM_SUBSTRATE=ibv and confirming that the correct codepath for the conditional compilation is taken

I was also able to reproduce the issue on an InfiniBand system without the patch, and confirmed that applying the patch results in correct execution.

> chpl examples/hello6-taskpar-dist.chpl 
> ./hello6-taskpar-dist.chpl  -nl 4
SEGFAULT

> ...apply patch....
> chpl examples/hello6-taskpar-dist.chpl 
> ./hello6-taskpar-dist.chpl  -nl 4
Hello, world! .....
......

[Reviewed by @jhh67]

bradcray commented 3 weeks ago

Thanks for taking care of this, @jabraham17!