Closed jabraham17 closed 1 week ago
This PR changes some of the imaginary overloads of trigonometric and hyperbolic functions in the Math module.
This PR deprecates the previously unstable overloads with a config const named useNewImaginaryTrig to switch to the new behavior.
useNewImaginaryTrig
Functions changed in the PR
proc cos(imag): real
proc cosh(imag): real
proc sin(imag): imag
proc sinh(imag): imag
proc tan(imag): imag
proc tanh(imag): imag
proc asin(imag): imag
proc atanh(imag): imag
Implements some of the changes outlined in #24506
Testing
Reviewed post-merge by @jeremiah-corrado
This PR changes some of the imaginary overloads of trigonometric and hyperbolic functions in the Math module.
This PR deprecates the previously unstable overloads with a config const named
useNewImaginaryTrig
to switch to the new behavior.Functions changed in the PR
proc cos(imag): real
proc cosh(imag): real
proc sin(imag): imag
proc sinh(imag): imag
proc tan(imag): imag
proc tanh(imag): imag
proc asin(imag): imag
proc atanh(imag): imag
Implements some of the changes outlined in #24506
Testing
Reviewed post-merge by @jeremiah-corrado