Try to remove calls to sleep() from test suite

[ronawho]

There are a number of tests that use sleep in our test suite.

It'd be ideal to get rid of as many sleeps as possible for a few reasons

• A lot of the time sleep is being abused as a way to wait for tasks to finish. This is race-y and not safe, and most of the time a sync statement should be used instead. These tests often show up as sporadic regressions.
• Some tests use sleep as a timeout mechanism. i.e. "if this tests doesn't complete in 3 seconds, quit" These tests should be using a .timeout file instead. This makes the errors more obvious in regression mails, and is safer, because there's no gaurentee that your sleeping task will wake up after 3 seconds
• Sleep increases testing time without adding much if any value, and makes it difficult to run multiple trials of tests
• Seriously, this adds a lot of pointless time to testing. Most of these sleeps, sleep for at least a second, which takes hundreds of times longer than the actual test.
• even more so than not doing a chapel sleep, we should never extern out to system sleep. This is all but guaranteed to not work under tasking layers like qthreads, where doing a pthread sleep is incredibly wrong.
• The only tests that should be using sleep, are ones that are testing sleep

I wonder if we should have some smoke test that looks for sleeps in test/. We'd need some way to mark a test as being allowed to have a sleep in it though

Here's (way too long of) a list of tests that sleep (or more accurately have text "sleep" in them somewhere), please check them off as they are fixed or as you discover that I lied and they don't actually sleep:

• [ ] exercises/boundedBuffer.chpl
• [ ] exercises/boundedBuffer2.chpl
• [ ] exercises/RandomNumber6.chpl
• [ ] extern/bradc/externClock.chpl
• [ ] extern/sungeun/externProcInClassShouldBeError.chpl
• [ ] functions/iterators/angeles/distAdaptativeWS.chpl
• [ ] functions/iterators/angeles/distAdaptativeWSv1.chpl
• [ ] functions/iterators/angeles/distAdaptativeWSv2.chpl
• [ ] functions/iterators/angeles/dynamic.chpl
• [ ] functions/iterators/angeles/guided.chpl
• [ ] functions/vass/sync-to-this-of-underlying-type.chpl
• [ ] memory/deitz/test_tricky_heap_case.chpl
• [X] memory/diten/useArrInBegin.chpl
• [X] memory/diten/useDomInBegin.chpl
• [X] modules/diten/mutualuse.chpl
• [X] modules/diten/mutualuse3.chpl
• [X] modules/diten/useInBegin.chpl
• [ ] modules/standard/Spawn/spawn-kill.chpl
• [x] modules/standard/Spawn/spawn-popen-wait.chpl
• [ ] modules/standard/Spawn/spawn-term.chpl
• [ ] modules/standard/Time/clearWhileRunning.chpl
• [ ] multilocale/bradc/needMultiLocales/writeThisUsingOn.chpl
• [X] multilocale/deitz/needMultiLocales/test_large_nb_fork_bug_diten.chpl
• [ ] multilocale/deitz/needMultiLocales/test_local_int_begin.chpl
• [ ] multilocale/deitz/needMultiLocales/test_on_begin2.chpl
• [ ] multilocale/deitz/needMultiLocales/test_termination1.chpl
• [X] multilocale/diten/needMultiLocales/coforallon_maxThreads.chpl
• [X] multilocale/diten/needMultiLocales/DijkstraTermination.chpl
• [X] multilocale/diten/needMultiLocales/nestedOn.chpl
• [X] multilocale/diten/needMultiLocales/remoteString.chpl
• [X] multilocale/diten/needMultiLocales/remoteString2.chpl
• [ ] multilocale/vass/this-in-taskfns-in-ctors.chpl
• [ ] optimizations/cache-remote/ferguson/correctness/seqreread.chpl
• [ ] parallel/begin/deitz/test_begin3.chpl
• [ ] parallel/begin/deitz/test_begin4.chpl
• [ ] parallel/begin/deitz/test_begin5.chpl
• [ ] parallel/begin/deitz/test_begin_sync.chpl
• [ ] parallel/begin/deitz/test_coforall_sugar1.chpl
• [ ] parallel/begin/deitz/test_coforall_sugar2.chpl
• [ ] parallel/begin/deitz/test_coforall_sugar3.chpl
• [ ] parallel/begin/deitz/test_heap_begin.chpl
• [ ] parallel/begin/deitz/test_nested_fn_begin1.chpl
• [ ] parallel/begin/sungeun/nested_fn_begin1.chpl
• [X] parallel/begin/vass/multi-yield-leader.chpl
• [ ] parallel/cobegin/bradc/exitone.chpl
• [ ] parallel/cobegin/deitz/test_many_threads.chpl
• [X] parallel/cobegin/diten/cobeginRace.chpl
• [ ] parallel/cobegin/hilde/reports.chpl
• [ ] parallel/cobegin/stonea/reports.chpl
• [ ] parallel/cobegin/waynew/cobegin_writelns.chpl
• [ ] parallel/serial/bradc/serialSingleStmt.chpl
• [ ] parallel/serial/figueroa/MultiLocaleSerial.chpl
• [ ] parallel/serial/figueroa/ToggleSerialState.chpl
• [ ] parallel/serial/waynew/begin1a.chpl
• [ ] parallel/serial/waynew/begin1b.chpl
• [ ] parallel/serial/waynew/cobegin1b.chpl
• [X] parallel/single/diten/simpleSingleAccess.chpl
• [ ] parallel/single/figueroa/ReadWriteMethods.chpl
• [ ] parallel/single/figueroa/SingleSyncWriteParam.chpl
• [ ] parallel/single/waynew/class0.chpl
• [ ] parallel/single/waynew/class1.chpl
• [ ] parallel/single/waynew/sarray.chpl
• [ ] parallel/single/waynew/simple1-int64.chpl
• [ ] parallel/single/waynew/simple1.chpl
• [ ] parallel/single/waynew/simple2.chpl
• [ ] parallel/single/waynew/simple3.chpl
• [ ] parallel/single/waynew/simple4.chpl
• [ ] parallel/sync/deitz/test_deadlock_detection1.chpl
• [ ] parallel/sync/deitz/test_sync_in_generic.chpl
• [X] parallel/sync/diten/tupleOfSync.chpl
• [ ] parallel/sync/figueroa/ReadMethods.chpl
• [ ] parallel/sync/figueroa/SingleSyncWriteParam.chpl
• [ ] parallel/sync/figueroa/WriteMethods.chpl
• [ ] parallel/sync/waynew/if1.chpl
• [ ] parallel/sync/waynew/if2.chpl
• [ ] parallel/sync/waynew/record1.chpl
• [ ] parallel/sync/waynew/record2.chpl
• [ ] parallel/sync/waynew/record2b.chpl
• [ ] parallel/sync/waynew/record2c.chpl
• [ ] parallel/syncStmt/bradc/beginsync.chpl
• [ ] parallel/syncStmt/bradc/cobeginSync.chpl
• [ ] parallel/syncStmt/bradc/coforallSync.chpl
• [ ] parallel/syncStmt/deitz/test_end1.chpl
• [ ] parallel/syncStmt/deitz/test_end2.chpl
• [ ] parallel/taskPar/figueroa/taskParallel.chpl
• [ ] parallel/taskPar/sungeun/private.chpl
• [ ] parallel/taskPool/figueroa/ManyThreads.chpl
• [ ] parallel/taskPool/figueroa/TooManyThreads.chpl
• [ ] parallel/taskPool/figueroa/TotalThreads.chpl
• [ ] performance/sungeun/multilocale/syncsingle.chpl
• [ ] release/examples/primers/learnChapelInYMinutes.chpl
• [ ] release/examples/primers/procedures.chpl
• [ ] release/examples/primers/timers.chpl
• [ ] studies/hpcc/HPL/vass/utils.chpl
• [ ] studies/shootout/chameneos-redux/hannah/chameneos-redux-v1.chpl
• [ ] trivial/deitz/other/timer1.chpl
• [ ] trivial/deitz/other/timer2.chpl
• [ ] users/ferguson/bug-zhao.chpl
• [ ] users/npadmana/mpi/deprecated/simple_mixed_works.chpl
• [ ] users/npadmana/mpi/ring.chpl
• [ ] users/vass/domain_with_on-all.chpl

Here's a list of tests that are allowed to have a sleep (please list a reason after the test name)

Test Name	Reason
modules/standard/Time/sleepTimeUnits.chpl	Testing the functionality of sleep()

[cassella]

Here's some off the end:

• parallel/taskPool/figueroa/TotalThreads.chpl ** It's using sleep to wait for tasks to run. It's testing that some of the tasks end up stuck on singles, so can't synchronize with them directly.

• performance/sungeun/multilocale/syncsingle.chpl ** I don't know what the sleep is doing. But it's config const'd out as start_test will run it.

• release/examples/primers/learnChapelInYMinutes.chpl sleep(1) so the user can see the lines of output show up one at a time. sleep(2) I think is so the user can see that the tasks are serializing on the lock$. *** I think this loop can let three tasks into the two-task-limit critical section

• release/examples/primers/procedures.chpl ** Using sleep I think so that the user can see the lines of output show up one at a time.

• release/examples/primers/timers.chpl ** Demonstrates that Timers and getCurrentTime() show a 1 second delta across a sleep(1)

• studies/hpcc/HPL/vass/utils.chpl ** Only VTimerSelfTest() calls sleep, and that function is not referenced under studies/hpcc

• studies/shootout/chameneos-redux/hannah/chameneos-redux-v1.chpl ** The only call to sleep is commented out.

• trivial/deitz/other/timer{1,2}.chpl ** Testing Timer

• users/ferguson/bug-zhao.chpl ** Used in a function countdown(seconds: int) to produce a second-by-second countdown *** The function is never called.

• users/npadmana/mpi/deprecated/simple_mixed_works.chpl ** Only use of sleep() is commented out.

• users/npadmana/mpi/ring.chpl ** This might be a "used for synchronization" sleep

• users/vass/domain_with_on-all.chpl ** Using sleep to wait for tasks to finish.