search

chapel-lang / mason-registry

Package registry for mason, Chapel's package manager
17 stars 25 forks source link

Fix yaml file #40

Closed ankushbhardwxj closed 4 years ago

ankushbhardwxj commented 4 years ago

refactored the YAML file to use only matrix

ankushbhardwxj commented 4 years ago

@ben-albrecht made the changes 👍

ankushbhardwxj commented 4 years ago

travisScript.bash seems to be running here though

ben-albrecht commented 4 years ago

travisScript.bash seems to be running here though

I think it's running now that this PR contains the correct yaml changes. I see it is failing though.

ankushbhardwxj commented 4 years ago

It failed the travisScript.bash because the script parses the dirname from the file changed( here .travis.yml ). I think we can merge this and I can make another test PR

ben-albrecht commented 4 years ago

Any idea how it's getting newPackage here?

https://travis-ci.com/github/chapel-lang/mason-registry/jobs/346813341#L792

ankushbhardwxj commented 4 years ago

Okay, consider a PR $mason_reg_home/Bricks/test/0.0.1.toml. The script parses the source field from the toml file and clones that repository as newPackage inside $mason_reg_home/Bricks/test.

ankushbhardwxj commented 4 years ago

The script gets the path and Toml file using the git command in the script.

ankushbhardwxj commented 4 years ago

When we parse the dirname using the git command, we get something like Bricks/test/0.0.1.toml. We could check if the dirname contains keyword "Bricks" and then proceed with checkPackage & mason publish --ci-check , else we exit

ben-albrecht commented 4 years ago

That sounds good. One other sanity check would be to make sure no .toml files were being added/modified to ensure someone isn't trying to add a package to somewhere outside of Bricks.

I'm going to merge this now and we can tackle that post-merge.