search

chapel-lang / mason-registry

Package registry for mason, Chapel's package manager
17 stars 25 forks source link

Add CHPL_RE2=bundled to Chapel CI build command #57

Closed bmcdonald3 closed 2 years ago

bmcdonald3 commented 2 years ago

For mason to be built, CHPL_RE2 must be set to bundled, so this adds that line to the Chapel build command.

ronawho commented 2 years ago

Does travis testing still run anymore? (I wouldn't expect it to, and we've been switching other repos to github actions)

bmcdonald3 commented 2 years ago

I'm not sure about that travis testing, I pretty much left that alone since I had no familiarity with it. Maybe we should drop the travis testing and port it to github actions?

ronawho commented 2 years ago

What motivated this change then? Based on the name I was expecting this to be a change to scripts used for travis?

bmcdonald3 commented 2 years ago

The github actions call the travis script and I'm not really sure how that works, but that travisScript.bash runs in the github actions in what at least looks like a regular github CI test.

Edit: the CI only runs when you modify one of the bricks, but here is an example: https://github.com/chapel-lang/mason-registry/runs/6279310389?check_suite_focus=true

bmcdonald3 commented 2 years ago

Like I think that script being named travisScript.bash is the only thing link to travis here, I don't see anything else that relates to travis in the github workflow or that script.

ronawho commented 2 years ago

Ok, so we already migrated to github actions and it just happens to be calling an old/existing script that was also used for travis.

bmcdonald3 commented 2 years ago

Ya, I think that is right, I wasn't sure if something was using the .travis.yml file, but I don't see anything in the repo using it. Do you think I am good to remove that?

ronawho commented 2 years ago

Nothing in the repo ever used it (just like nothing in the repo uses the github actions yml)

I'm not really familiar with this repo, but based on https://github.com/chapel-lang/mason-registry/pull/48 it looks like things were switched to github actions so it seems like it should be safe to remove. I'd probably remove the .travis.yml file and rename travisScript.bash to ciScript.bash or something more generic