chapeldev / cdo

Chapel Data Object
Apache License 2.0
10 stars 6 forks source link

Refactoring and addition of features to MySQL implementation #26

Closed souris-dev closed 3 years ago

souris-dev commented 3 years ago

The existing code for the MySQL implementation lacked certain features and could use a revamp, so I took my liberty and refactored it while adding a couple of new things to it.

Here is a short non-extensive synopsis of the changes you should find:

The tests can be run using mason test, but please ensure that the TestDBInit.chpl file is compiled (using make test_db_init) and executed first before the tests are run as this file initializes the database tables for the tests, and that the database credentials/details are also updated in the tests. Alternatively, you can also use the runtests.sh script to run the tests (if this script is used, it ensures that the above step of compiling and executing TestDBInit.chpl is performed before running the tests).

I'd really appreciate feedback on the above and any other suggestions, and I hope that this PR could help in making this library even more useful.

Thanks!

krishnadey30 commented 3 years ago

You are missing new line at end of many files. Please add that.

souris-dev commented 3 years ago

@krishnadey30 Thanks for reviewing my PR! I've made the recommended changes and addressed the comments, please do have a look whenever you have the time. @ben-albrecht @marcoscleison @buddha314 Would love feedback/comments so do have a look whenever time permits :-). Thanks!

souris-dev commented 3 years ago

@ben-albrecht Thanks for the review! I've addressed the comments and made the suggested changes, do have a look when possible. (I've also changed the indentation to 2 spaces for convention.)

souris-dev commented 3 years ago

Thanks for the reviews! I've made the changes suggested by @krishnadey30 and made the PR ready to be merged.