sourcery-ai[bot]
commented
4 years ago Sourcery Code Quality Report (beta)
❌ Merging this PR will decrease code quality in the affected files by 0.22 out of 10.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.20 | 2.17 | -0.03 🔵 |
| Method Length | 63.53 | 77.94 | 14.41 🔴 |
| Quality | 8.34 | 8.12 | -0.22 🔴 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 1876 | 1721 | -155 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| doc_src/source/conf.py | 9.14 | 9.14 | 0.00 |
| libchickadee/init.py | 9.58 | 9.58 | 0.00 |
| libchickadee/chickadee.py | 7.48 | 7.45 | -0.03 🔴 |
| libchickadee/resolvers/virustotal.py | 7.71 | ||
| libchickadee/test/test_chickadee.py | 8.53 | 8.49 | -0.04 🔴 |
| libchickadee/test/test_resolver_virustotal.py | 8.62 |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Overall | Recommendation |
|---|---|---|---|---|---|
| libchickadee/resolvers/virustotal.py | ProResolver.parse_vt_resp | 6 | 439.26 | 4.53 | Split out functionality |
| libchickadee/chickadee.py | entry | 8 | 237.70 | 5.06 | Split out functionality |
| libchickadee/test/test_chickadee.py | ChickadeeFileTestCase.setUp | 0 | 235.38 | 5.87 | Split out functionality |
| libchickadee/chickadee.py | arg_handling | 0 | 219.28 | 6.00 | Split out functionality |
| libchickadee/test/test_chickadee.py | ChickadeeFileTestCase.test_ipapi_resolve_query_folder | 0 | 157.98 | 6.71 | Split out functionality |
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Initial support for resolving IP address information using VirusTotal.
Tasks: