chapkachapka / j-sheridan-le-fanu_the-wyvern-mystery

Other
0 stars 0 forks source link

Review #1

Closed weijia-cheng closed 5 months ago

weijia-cheng commented 5 months ago

Typography

Spelling

Semantics

Metadata

CSS

#chapter-14 blockquote p{
    text-indent: 0;
}

#chapter-14 blockquote p:nth-of-type(2){
    text-indent: 3em;
}

#chapter-14 blockquote p:nth-of-type(3){
    text-indent: 6em;
}

#chapter-14 blockquote p:nth-of-type(4){
    text-indent: 9em;
}

Meta

chapkachapka commented 5 months ago

These should all be taken care of, thanks!

weijia-cheng commented 5 months ago

The changes themselves look good, however when you updated the editorial commit message, it seems you merged the changes instead of force-pushing them. As a result you duplicated your commit history here instead of rewriting the editorial message. Since this can be somewhat complicated issue to resolve, I dropped all of the duplicated commits by interactive rebasing from d866465724a210fbafa5da35a7d00648abc4b5d8 and pushed the cleaned history to my own version of the repository: https://github.com/weijia-cheng/j-sheridan-le-fanu_the-wyvern-mystery