search

chaplinjs / chaplin

HTML5 application architecture using Backbone.js
http://chaplinjs.org
Other
2.85k stars 232 forks source link

IE8 #378

Closed paulmillr closed 11 years ago

paulmillr commented 11 years ago

jQuery 2.0 will soon be out without IE8 support. It also seems Moviepilot no longer supports IE8. Do we still want to support it?

With IE9, we can drop ALL checks for ES5 stuff. No more Object.freeze? etc.

molily commented 11 years ago

All of our apps (@9elements) have at least basic support for IE8 and also most clients demand that. That doesn’t mean that everything works fast and looks great, but there shouldn’t be a JS exception in a core module that crashes everything. When we don’t support IE8, most of the time there’s a good reason like missing SVG or Canvas that’s can’t be polyfilled easily. It shouldn’t be the Chaplin core responsible for not supporting IE8. The ES5 stuff in Chaplin is rather optional.

Moviepilot doesn’t support IE8 actively and shows a browser upgrade message. There are some minor rendering errors and the performance is bad, but the basic use cases work quite fine in IE8. I can log in, read article, follow movies etc.

andriijas commented 11 years ago

I wouldn't mind but deeming browser stats I think it's to soon.

mehcode commented 11 years ago

I would say that we make the switch when jQuery does (it's not too soon as 1.9 isn't released yet).

molily commented 11 years ago

http://blog.jquery.com/2013/01/15/jquery-1-9-final-jquery-2-0-beta-migrate-final-released/ ;)

mehcode commented 11 years ago

Well damn. Apparently I didn't read the paper this morning. Thank you @molily.

Though I still suggest we make the switch when 2.0 has an official release.

andriijas commented 11 years ago

That was my thought exactly.

On Tuesday, January 15, 2013, Ryan Leckey wrote:

Well damn. Apparently I didn't read the paper this morning. Thank you

@molily https://github.com/molily.

Though I still suggest we make the switch when 2.0 has an official release.

— Reply to this email directly or view it on GitHubhttps://github.com/chaplinjs/chaplin/issues/378#issuecomment-12280739.

molily commented 11 years ago

Why should we switch when jQuery 2 is released? Every user can decide on their own whether to use jQuery 1.9 or 2 or Zepto. Both jQuery 1.9 and 2.0 will be maintained for some time. The ES5 stuff in Chaplin that needs an opt-out for IE8 is insignificant (It’s the ? in Object.freeze? this for example). As long as this is the case, we should support IE8.

chrisabrams commented 11 years ago

We need support for IE 8 on delicious.com - if you do decide to remove it, it would be nice to maintain an option/plugin to keep it.

paulmillr commented 11 years ago

@chrisabrams Del.icio.us uses Chaplin? woah. that will be kind of nice addition to our examples, if you won’t mind.

chrisabrams commented 11 years ago

@paulmillr yeah I meant to tell you, but just been focusing on getting the site up. Feel free to use us as an example. The site is loading much much faster than when it was on Python.

akre54 commented 11 years ago

@chrisabrams looks like it uses brunch too, yeah? Cool!

chrisabrams commented 11 years ago

@akre54 we use brunch locally - the fact that it only re-builds the changes and not the entire project is awesome. We use grunt when testing and deploying to production because we need some extra features that brunch doesn't have. Had to pester @paulmillr a few times to get brunch and grunt to play nice together ;) (wasn't ever brunch's fault).