chaplinjs / chaplin

HTML5 application architecture using Backbone.js
http://chaplinjs.org
Other
2.85k stars 231 forks source link

Fix external links detection #879

Closed shvaikalesh closed 8 years ago

shvaikalesh commented 8 years ago

Resolves https://github.com/chaplinjs/chaplin/issues/878.

Handled some edge cases with target and iframes. Removed hardcoded protocols. Now it handles different ports correctly. Replaced jsdom-global with my-own-stuff because jsdom fails to resolve some relative links on about:blank and jsdom-global does not provide a way to set url. jsdom-assign provides valid and real-world-like urls, cookies etc. And it works on require, w/o closure.