search

chapmanb / bcbb

Incubator for useful bioinformatics code, primarily in Python and R
http://bcbio.wordpress.com
603 stars 243 forks source link

Fix error with biopython 1.81 #137

Closed abretaud closed 1 year ago

abretaud commented 1 year ago

A possible solution for #136, tested on a minimal sample with python 3.9. Any review/test is welcome to make sure it works in all situations.

With this patch, bcbio-gff should work equally with biopython <=1.80 and biopython 1.81

I know bcbio-gff is not actively maintained anymore, but there's still a ton of code using it, so having a new release with this fix would make life easier

abretaud commented 1 year ago

ping @chapmanb in case you were not notified :)

chapmanb commented 1 year ago

Thanks so much for the fix and apologies for being slow in getting it merged. I'll roll a new release right now as well. Really appreciate you being on top of this.

abretaud commented 1 year ago

Wonderful thanks a lot for the merge and release @chapmanb! :+1: