search

chapmanb / bcbb

Incubator for useful bioinformatics code, primarily in Python and R
http://bcbio.wordpress.com
610 stars 243 forks source link

GFFOutput.py #90

Closed TheOneHyer closed 9 years ago

TheOneHyer commented 10 years ago

When running this file using Python 3.4.1, several errors arose. Namely, ".haskeys()" is obsolete and should be replaced by "for item in dictionary". These changes have been made in this forked version of the file and it works flawlessly when tested.

TheOneHyer commented 10 years ago

When running this file using Python 3.4.1, several errors arose. Namely, ".haskeys()" is obsolete and should be replaced by "for item in dictionary". These changes have been made in this forked version of the file and it works flawlessly when tested. This will make the file more universally applicable.

chapmanb commented 10 years ago

Alex; Thanks for the Python 3 fixes. I'd be happy to pull these in and was going to convert your separate file into GFF/GFFOutput.py when I realized you'd already been working on this. If you want to submit a pull request that applies these fixes in place I'd be happy to accept that so you'll get full credit for your work in the git history. Thanks again.

TheOneHyer commented 10 years ago

Okay, Pull Request submitted, thanks

chapmanb commented 9 years ago

Alex; Apologies about the delays in pulling this in. I applied these fixes and also included them in GFFParser as well, so hopefully v0.6.1 should work cleanly for you on Python3. Thanks again for the contribution. Much appreciated.

TheOneHyer commented 9 years ago

No problem, thank you for providing this service in the first place as the ability to read and write GFF files has been enormously helpful with my research.

Sent from Windows Mail

From: Brad Chapman Sent: ‎Sunday‎, ‎October‎ ‎26‎, ‎2014 ‎4‎:‎32‎ ‎AM To: chapmanb/bcbb Cc: Molly Weasley

Alex; Apologies about the delays in pulling this in. I applied these fixes and also included them in GFFParser as well, so hopefully v0.6.1 should work cleanly for you on Python3. Thanks again for the contribution. Much appreciated.

— Reply to this email directly or view it on GitHub.