search

chapmanjacobd / library

80+ CLI tools to build, browse, and blend your media library: an index for your archive.
BSD 3-Clause "New" or "Revised" License
355 stars 9 forks source link

Enhance yt_dlp's progress_hooks to include downloaded_bytes #32

Closed deldesir closed 6 months ago

deldesir commented 6 months ago

This pull request enhances yt_dlp's progress_hooks to include the downloaded_bytes parameter.

Example data dictionary (for reference purpose):

{
    'status': 'downloading',
    'downloaded_bytes': 2048,
    'total_bytes': 10000000,
    'tmpfilename': './example/tmpfile.mp4.part',
    'filename': './example/example_video.mp4',
    'eta': 120,
    'speed': 500000.0,
    'elapsed': 1.5,
    '_eta_str': '02:00',
    '_percent_str': '  0.0%',
    '_speed_str': '488.28KiB/s',
    '_total_bytes_str': '9.54MiB'
}
holta commented 6 months ago

@deldesir if this PR is high-priority towards solving things like...

...please mention that — so all the pieces to the puzzle are visible?

chapmanjacobd commented 6 months ago

This was approved yesterday but I don't usually click merge in case there are other commits or changes that need to be added by the owner of the pull request. Because it is approved I believe the owner of the PR can click merge

holta commented 6 months ago

I believe the owner of the PR can click merge

Turns out that's not true 🙂

I don't usually click merge in case there are other commits or changes that need to be added

💯

(We don't need Darwin to tell us almost all designs evolve over time ;-)