search

chapmanu / cascade-assets

Manage assets outside of cascade.
0 stars 4 forks source link

In Campus map, Rinker search results in a 404 page. #124

Closed tatwell closed 7 years ago

tatwell commented 7 years ago

Trello card has details:

https://trello.com/c/IDOumT6y/19-defect-rinker-search-results-in-a-404-page

tatwell commented 7 years ago

@sharissis-brei emailed following info about fix:

The issue was that the form action was set to "return: false", which led to a 404 page. I've removed this and added some code to prevent the form from actually submitting if the user hits enter. The autocomplete still functions as expected.

tatwell commented 7 years ago

@sharissis-brei Can you identify the files you changed in Dev Cascade? Once we've identified them, @mandythomas and I will take this issue over and handle deployment. Thanks!

sharissis-brei commented 7 years ago

Hi @tatwell and @mandythomas, I changed /_cascade/templates/Campus Map/Landing in dev-cascade so far. No changes outside the CMS were needed.

I'll also be updating this in the production CMS shortly as well.

tatwell commented 7 years ago

@sharissis-brei No need to update production. We'll review changes in /_cascade/templates/Campus Map/Landing and handle production deployment ourselves.

If we have any questions, we'll email you or post them here (which should trigger email). Thanks.

tatwell commented 7 years ago

@mandythomas Diffed versions of /_cascade/templates/Campus Map/Landing using this site:

https://www.diffchecker.com

Changed l. 70. Was:

<form action="return false;" id="virtualTour-searchFieldForm">

Now:

<form action="" id="virtualTour-searchFieldForm" onsubmit="event.preventDefault()">

Works for me.

sharissis-brei commented 7 years ago

I saw this slightly too late – I just pushed the change live. I hope this isn't a problem. Please let me know if you'd like me to revert.

tatwell commented 7 years ago

@sharissis-brei I don't expect a problem. In future, we'll handle production deployment.

@mandythomas, can you confirm fix with Ross? If confirmed, we can close this ticket.

sharissis-brei commented 7 years ago

Great, thanks for understanding. Let me know if you need anything else from our end.

mandythomas commented 7 years ago

yes I confirm that it's working on www.chapman.edu. I had noticed that Sarah moved it in to prod Cascade right after I got back from our afternoon meeting. Tried to call you to ask if you'd approved and/or knew that but didn't catch you at your desk. Now I see we just had a miscommunication. Didn't check github til just now. I think we're all good.