chaps-io / gush

Fast and distributed workflow runner using ActiveJob and Redis
MIT License
1.05k stars 106 forks source link

Adds keyword arguments to configure - Ruby 3.0 support #105

Closed toreym closed 2 months ago

toreym commented 1 year ago

Background

In ruby 2.7 calling a method like configure(*@arguments) would allow for keyword arguments in a method definition like def configure(my_param:) In Ruby 3.0, positional arguments and keyword arguments have been separated. So they must be accounted for individually

Overview of change

This PR will allow for a configure that accepts positional and keyword arguments as recommended in ruby 3. It will also account for any workflows in redis that were created with a prior version allowing for a drop-in replacement.

Potential breaking changes

matiasmasca commented 2 months ago

@mlen @krzyzak @keqi @ferusinfo did you consider adding this PR? What will you do about this issue?

pokonski commented 2 months ago

This is now released under v4.0.0 using a different approach https://github.com/chaps-io/gush/pull/113/files

@matiasmasca @toreym