Wrong workflow status after failed jobs

chaps-io / gush

Fast and distributed workflow runner using ActiveJob and Redis

MIT License

1.03k stars 103 forks source link

Closed ferusinfo closed 7 years ago

ferusinfo commented 8 years ago

Currently if any jobs will fail (by throwing an exception in a job), the status of the workflow is not properly updated:

pokonski commented 8 years ago

Can you confirm this happens even after reloading the workflow as described here? https://github.com/chaps-io/gush#in-ruby

ferusinfo commented 8 years ago

Yes, I can confirm that flow.reload isn't changing the status.

pokonski commented 8 years ago

Alright, marking it as a bug and consulting my :8ball: to find the issue :D

ferusinfo commented 8 years ago

Great to hear that, I will try to find it myself as well by reading the source.

pokonski commented 8 years ago

@ferusinfo I pushed a fix and a spec for your case. Have a look at master :)

ferusinfo commented 8 years ago

I will look into this later - but so far so good! :+1: