Closed ferusinfo closed 8 years ago
Awesome :) I'm glad you took a shot at this, overall looks great, since payloads are a bit tricky, but I have some suggestions left in the commits.
I've added a new commit with changes that you've proposed - can you take a look at it?
Great! I'll test it on my projects on the weekend and merge then :)
:+1: I will use my branch in my project production env for the time being ;)
@pokonski just FYI - I am now running this on my production servers for almost 2 days (multiple same class named jobs with different parameters + summary job with Slack hook) - no problems atm.
The only thing that I will need to add myself is better failure handling - the inability to requeue the job in sidekiq is painful (especially that I rely on multiple http requests that might fail at some point).
Awesome, had a look at it and looks great :+1: Much appreciated! Tiny code style details, but I will change them after merging :)
Hey, like we've discussed in https://github.com/chaps-io/gush/issues/21, I need to have unique names for jobs that run the same class with different params.
Here is my solution to the problem - I've also updated rspec tests for it (all green now), as well as added mine that is using the new
nameize_payloads!
method. What it does is changing the way payloads are delivered - they can be either delivered as an array of strings or hashes, depending on how detailed your payloads needs to be:Hope that you can merge this, so everyone can use it.