search

chaps-io / gush

Fast and distributed workflow runner using ActiveJob and Redis
MIT License
1.03k stars 103 forks source link

Downgrade ActiveJob dependency to 4.2 #54

Closed iacobus closed 6 years ago

iacobus commented 6 years ago

Hi, thank you for your work with Gush. We're considering using it for a Rails 4.2 project but the gemspec currently has a ~> 5.0 dependency. However, we don't think that there are any meaningful differences for gush — all tests pass with 4.2.

Is there anything else that we should be checking? If not, what do you think about merging this? I imagine there are still a good number of Rails 4 projects out there.

Thank you!

pokonski commented 6 years ago

Hey, Jacobo! I don't think 5 is required but can you make it more relaxed? Like this:

'>= 4.2' , '< 6.0'

? Can't be sure of the syntax but should be close to it :) This way we can have people using Rails 5 happy, too.

iacobus commented 6 years ago

@pokonski yes, definitely. I always get those wrong. I made it 4.2.7, sort of randomly. Tests pass in that precise version, as well as latest 4.x (4.2.10). Thank you.

iacobus commented 6 years ago

Hi @pokonski — any next steps here, or is it good to merge? :)

pokonski commented 6 years ago

Good to go! Sorry, missed the fact that you pushed the update :)

I will push a new version later today and let you know here!

iacobus commented 6 years ago

Oh, great. Thank you @pokonski — what's the release cadence? Should I expect a new version including this to come out soon?

[EDIT: I'm sorry, I missed the second line of your message... Disregard my note. Thanks!]

pokonski commented 6 years ago

@iacobus 1.1.1 is now released and contains your change, thanks again! Wasn't "later today", sorry for that :grin:

iacobus commented 6 years ago

🚀 thank you!