search

chaps-io / gush

Fast and distributed workflow runner using ActiveJob and Redis
MIT License
1.03k stars 103 forks source link

Add Gush::Job#skip! #66

Open ace-subido opened 5 years ago

ace-subido commented 5 years ago

As per discussion in #65 this pull request adds a Gush::Job#skip! that would mark a job as skipped, and returns from the point where self.skip! is called. After calling self.skip!, the workflow continues on with the other jobs.

Note: @pokonski was thinking of adding .skip_remaining! on another PR to keep the PR's small. What do you think? Or should I include that suggestion in this PR too?

pokonski commented 5 years ago

I tested it but have one note: could you add an integration spec for this case just to make sure descendants run?

Here: https://github.com/chaps-io/gush/blob/master/spec/features/integration_spec.rb

natemontgomery commented 4 months ago

@ace-subido I wanted to check in and see about updating this, it's something I think is worth implementing for sure! If you would rather not handle updating the branch I can hop on it, would definitely rather not duplicate a PR.

ace-subido commented 4 months ago

for sure! go ahead, I've not worked/looked on this for a long time and you may have better context.