search

chapter-three / AppleNewsAPI

This is a PHP library that allows you to publish content to Apple News and construct documents in the Apple News JSON format.
MIT License
39 stars 25 forks source link

Fix PHP notices that are raised in unit test suite. #9

Open m4olivei opened 7 years ago

m4olivei commented 7 years ago

Tests pass, but there are a number of PHP notices that are raised, eg.

https://travis-ci.org/chapter-three/AppleNewsAPI/jobs/192384948

These should be cleaned up.

m4olivei commented 7 years ago

I tried for an hour or so to come up with something that would work to test and assert PHP notices and errors, but wasn't able to. Seems like something about how the json() methods do their work, doesn't allow PHPUnit to bubble up an exception correctly to be caught by the test case. :man_shrugging: