chapter-three / next-drupal

Next.js for Drupal has everything you need to build a next-generation front-end for your Drupal site: SSG, SSR, and ISR, Multi-site, Authentication, Webforms, Search API, I18n and Preview mode (works with JSON:API and GraphQL).
https://next-drupal.org
MIT License
639 stars 178 forks source link

Node.js v16 has been deprecated #530

Open JohnAlbin opened 1 year ago

JohnAlbin commented 1 year ago

Node.js v16 was deprecated ahead of the normal schedule. It was deprecated on Sept 11, 2023

This will also affect Vercel hosting on Febr 6 2024 when Vercel disabled Node.js v16 hosting.

Currently, the .nvmrc file is pinned to v16.19.0, which is unnecessarily specific imho. It should be set to v18 (so developers can use whatever specific version of v18.x that they have.

The package.json also specifies:

 "engines": {
    "node": ">=16.19.0"
  }

This should be changed to v18.0.0.

JohnAlbin commented 1 year ago

I'm not sure the engines entry gains us anything.

We want to support any supported version of Node.js, and, afaik, we don't have any specific supported Node.js versions that we are not compatible with.

JohnAlbin commented 1 year ago

We'll keep v16 support through 2.x. And drop it with 3.x.