chaquo / chaquopy

Chaquopy: the Python SDK for Android
https://chaquo.com/chaquopy/
MIT License
807 stars 132 forks source link

Added DepthAI package and required fixes #1059

Closed themarpe closed 8 months ago

themarpe commented 9 months ago

This contains a couple of parts to get everything in place:

This is an iteration/simplification of: https://github.com/chaquo/chaquopy/pull/1010, to not require bump of API. To circumvent that, package had to be patch in the background to accomodate for older NDA and explicit link to -lpython3.x had to be added as a patch.

Otherwise a more straightforward PR and still functions as expected

mhsmith commented 9 months ago

Thanks, and I'm sorry for not responding to your previous PR – it touched a number of complex areas, so it wasn't easy for me to find time to review. This one looks a lot easier to handle.

One of those areas which has become a bit simpler in the last few days is actually installing and running CMake. Please merge from the master branch to pick up these:

Also, to add a new package, we need a test script to verify that it works. Please do the following:

mhsmith commented 9 months ago

To circumvent that, package had to be patch in the background to accomodate for older NDA

What does "NDA" mean?

themarpe commented 9 months ago

Thanks for the comments! Addressed & force pushed!

To circumvent that, package had to be patch in the background to accomodate for older NDA

What does "NDA" mean?

Sorry, meant NDK here.


Added test case, tested against

mhsmith commented 8 months ago

It looks like since you explicitly added libpython to the link in the CMakeLists file, the changes to the toolchain file were no longer necessary, so I've removed them.

The cmake-example recipe had to be fixed in the same way – removing the --no-undefined flag allowed it to build, but without the libpython link, the module still couldn't be loaded at runtime.

I was unable to add these changes to this PR because you apparently disabled the "Allow edits from maintainers" option when you created it. Please leave this enabled in future PRs.

This package is now in the public repository for Python 3.8 - 3.12. Thanks for the contribution!