Feature/settings url length

char0n / django-brevisurl

Django app for shortening urls

Other

9 stars 10 forks source link

Feature/settings url length #19

Closed motiteux closed 10 years ago

motiteux commented 11 years ago

This pull request just uses a new settings to customize the length of the original url. Url to be shortened might be containing a long list of query parameters.

Thus, a long url passes the URL validator.

Added tests test_model_save_too_long_original_url

char0n commented 11 years ago

Overall this pull request is acceptable, if you fix the issues I highlighted. Thanks

motiteux commented 11 years ago

Thanks for the review. I will look into it.

motiteux commented 10 years ago

Modifying the use of local brevis settings in models and migrations. Let me know if this is fine.

char0n commented 10 years ago

Thanks, I'll have a look at it during weekend.

motiteux commented 10 years ago

Alas, here we go. Thanks

motiteux commented 10 years ago

Hello @char0n Do you have anything you need for this PR to be happily part of brevis? ;]

Thanks!

char0n commented 10 years ago

It looks good. I'll give it a go during the weekend. Thanks

char0n commented 10 years ago

Merged to master. Thanks.

char0n commented 10 years ago

Released 2.0.0 on pypi