search

char0n / django-brevisurl

Django app for shortening urls
Other
9 stars 10 forks source link

Refactor files to work with Django 1.11 and Python 3.6.1 #29

Open arnoldchoa91 opened 7 years ago

char0n commented 7 years ago

@arnoldchoa91 why closing it ? Seemed legit to me.

arnoldchoa91 commented 7 years ago

@char0n My bad. Closed it accidentally. Could you check this please as this would potentially break backward compatibility? Thanks.

char0n commented 7 years ago

@arnoldchoa91 would you like to become maintainer of this library ? Would grant you access and find my pypi credentials so that we could release new versions.

The thing is that I am currently not in python stack anymore and your pull request looks like you know what you are doing.

What do you think ?

lemuelf commented 7 years ago

@arnoldchoa91 Take this please and update the project in pypi once this has been merged.

arnoldchoa91 commented 7 years ago

@char0n Yes please. That sounds good. Thank you.

@lemuelf Do we need to work on backward compatibility here? As it may break for other people using this library?

lemuelf commented 7 years ago

@arnoldchoa91 I think that would be beneficial to all. Django supported versions and LTS releases, and python versions supported by Django, at least.

char0n commented 7 years ago

Will return from holliday in a couple of days. W'll move forward from there...

On May 4, 2017 1:58 PM, "Lemuel Formacil" notifications@github.com wrote:

@arnoldchoa91 https://github.com/arnoldchoa91 I think that would be beneficial to all. Django supported versions and LTS releases, and python versions supported by Django, at least.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/char0n/django-brevisurl/pull/29#issuecomment-299154005, or mute the thread https://github.com/notifications/unsubscribe-auth/AALzBkTrSwt7MZaDosaGudOii5yxh9psks5r2a9KgaJpZM4NGAa1 .

char0n commented 7 years ago

@arnoldchoa91 added you as a collaborator to this repo. Feel free to manage it reasonably. I will try to recover pypi credentials to release a new version. There are also another PR waiting to be merged. Feel free to manage them also.

arnoldchoa91 commented 7 years ago

Thanks @char0n. I'll see what I can do. I'll also look into other PRs.

char0n commented 7 years ago

@arnoldchoa91 I've reacquired credentials to pypi. Create an account on pypi or give me your pypi login. I will make you package maintainer.

arnoldchoa91 commented 7 years ago

Hi @char0n. Hope you're doing well. Sorry I didn't get back to this sooner. I got caught up in work lately. Here's my pypi username: arnoldchoa.

char0n commented 7 years ago

@arnoldchoa91 you're good to go. You should be able to release on pypi now.