search

char0n / ramda-adjunct

Ramda Adjunct is the most popular and most comprehensive set of functional utilities for use with Ramda, providing a variety of useful, well tested functions with excellent documentation.
https://char0n.github.io/ramda-adjunct/
BSD 3-Clause "New" or "Revised" License
680 stars 85 forks source link

Increase code coverage to 100% #454

Open guillaumearm opened 6 years ago

guillaumearm commented 6 years ago

The 98% codecov badge attracted my attention and I fall on this : https://codecov.io/gh/char0n/ramda-adjunct/src/8cc269fcdf3125354aceae18c564538be72e89a5/src/fantasy-land/util.js#L22

So, I grep for it : 

$ git grep typeEquals
src/fantasy-land/util.js:// typeEquals :: Monad a => String -> a -> Boolean
src/fantasy-land/util.js:export const typeEquals = curry(

typeEquals is not used, is it normal ?

char0n commented 6 years ago

Yeah it's normal. These functions are for asserting FL monad types. The problem is that they are not tested. They are still being exported as public API. So If we cover them with tests we should be OK.

const { typeEquals } = require('ramda-adjunct/lib/fantasy-land/util');