charafau / json2builtvalue

Json to Dart built_value classes generator
Apache License 2.0
153 stars 24 forks source link

`BuiltValueField` is optional #8

Closed davidmorgan closed 4 years ago

davidmorgan commented 5 years ago

Thanks for the great tool :)

Just one question/observation--the BuiltValueField annotation isn't needed, the wireName by default is taken directly from the field name--would it make sense to omit it?

charafau commented 5 years ago

Hello David! Thanks for mentioning my small tool and thanks for built_value :)

I know BuiltValueField is optional, but I like to clearly specify it in classes, because then I can rename fields without thinking about json structure. I also learned that it's good t have when I was obfuscating code with gson bank on android days. I think I could make some checkbox on top with option but first I need to clean this project a little bit and make deployment easier.

davidmorgan commented 5 years ago

Makes sense, thanks :)