charettes / django-colorful

Extension to the Django web framework that provides database and form color fields
https://pypi.python.org/pypi/django-colorful
MIT License
169 stars 58 forks source link

Python 3 #11

Closed jvc26 closed 10 years ago

jvc26 commented 10 years ago

This includes full Python 3 compatibility, and a rough testsuite to check that the changes work across python versions.

Highlights

charettes commented 10 years ago

Hi @jvc26,

Thanks a lot for doing this, this is some really impressive work!

I left a couple of small comments, mostly nitpicks.

Once they are fixed I'll make sure to merge and issue a new release. Could you also create and AUTHORS file and added yourself? You definitely deserve credit for what you've done here.

jvc26 commented 10 years ago

I think the latest set of commits address the above comments, will check back here if further issues - thanks!

charettes commented 10 years ago

Looking good, I'll merge!