search

charettes / django-colorful

Extension to the Django web framework that provides database and form color fields
https://pypi.python.org/pypi/django-colorful
MIT License
169 stars 58 forks source link

Fix to improve compatibility with django-parsley #6

Closed johanmeiring closed 11 years ago

johanmeiring commented 11 years ago

django-parsley's regex matching is not case-insensitive, so the provided regex (caps) and the values that are inserted by the colorpicker (lowercase) cause client-side validation to fail. This simple commit aims to fix this particular case without necessarily affecting anything else negatively.

Use it, don't use it... up to you :)

charettes commented 11 years ago

The real solution would be to fix django-parsley to include the data-regexp-flag parsley attribute based on the flags of the compiled pattern.

charettes commented 11 years ago

Submited a PR (agiliq/Django-parsley#20) to django-parsey to fix this issue.

johanmeiring commented 11 years ago

Sweet, makes perfect sense. Thanks for the patch to django-parsley then :)