search

chargebee / chargebee-node

Node.js library for the Chargebee API.
https://apidocs.chargebee.com/docs/api?lang=node
MIT License
46 stars 30 forks source link

Specify return type of configure method #48

Closed gdelataillade closed 1 month ago

gdelataillade commented 1 month ago

Description

This Pull Request addresses a critical TypeScript error (TS7010) in the configure method, which lacks a return type annotation and implicitly has an any return type. This is not just a warning; it is an error that prevents TypeScript code from compiling successfully, especially when the noImplicitAny compiler option is enabled.

I have added an explicit void return type to the configure method to resolve this error. This change is essential to ensure that the TypeScript code compiles without issues, which is necessary for the successful deployment of my Google Cloud Function.

Urgency

Please review and merge this PR as soon as possible to unblock the deployment process. The current compilation error directly impacts our ability to deploy.

This description clearly outlines the issue, the solution, and the urgency, making it easier for the maintainers to understand and prioritize your PR.

Screenshot

CleanShot 2024-09-02 at 15 13 20@2x
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

yelkamel commented 1 month ago

I have the same problem, this need to be merge

cb-sriramthiagarajan commented 1 month ago

Hi @gdelataillade @yelkamel, we've just released v2.41.1 with this fix. Can you please check if this works fine for you?

Also, it'd be great if you could give v3 beta a go and share feedback :)

gdelataillade commented 1 month ago

Seems to work, thanks. OK I'll try v3 and I'll let you know if I have any issue.