chargebee / chargebee-php

PHP library for the Chargebee API.
https://apidocs.chargebee.com/docs/api?lang=php
MIT License
72 stars 62 forks source link

Improved attribute name consistency and documentation #18

Closed brianmuse closed 3 years ago

brianmuse commented 7 years ago

I noticed some confusing inconsistencies with some of the models.

Invoice::$allowed uses camel casing for attributes. LineItem::$allowed however, uses snake case with underscores.

It'd be easier to work with these objects if there was a common style.

On a second related note, it would be hugely beneficial when working with these classes if the properties were documented using PHPDoc in a way that most IDEs support.

For example:

/**
 * @property string $id
 * @property string $subscription_id
 * @property int $date_from
 * ...
 */
class ChargeBee_InvoiceLineItem extends ChargeBee_Model
{
cb-rakesh commented 3 years ago

This has been fixed in v3.0.0