search

chargebee / chargebee-ruby

Ruby library for the Chargebee API.
https://apidocs.chargebee.com/docs/api?lang=ruby
MIT License
32 stars 60 forks source link

Switch to MultiJson? #30

Open bjeanes opened 6 years ago

bjeanes commented 6 years ago

Hi,

Any chance you'd consider switching your JSON dependency to MultiJson? This allows the user to decide the JSON implementation themselves, while still allowing json_pure as an option for those that want it.

The reason for this is that json_pure defines ::JSON and is not always API compatible with other implementations. If another gem uses a different library that also defines ::JSON, the two implementations can fight and slightly different behaviours can occur. Including Chargebee in the project has caused a lot of JSON errors elsewhere for me because of issues like this.

xn commented 6 years ago

@bjeanes #33

bjeanes commented 6 years ago

Awesome. Thanks for taking the time to PR. I had hoped to if I got response here but I'm glad someone stepped up to my plate in the meantime!