search

chargebee / chargebee-ruby

Ruby library for the Chargebee API.
https://apidocs.chargebee.com/docs/api?lang=ruby
MIT License
32 stars 60 forks source link

Since RSpec 2.11. Specs should use expect(foo).to and not foo.should #48

Closed juliancheal closed 2 years ago

juliancheal commented 4 years ago

RSpec is giving deprecation warnings, this PR fixes those, by changing foo.should to expect(foo).to

Below is the warning from Rspec

Using `should` from rspec-expectations' old `:should` syntax without
explicitly enabling the syntax is deprecated. Use the new `:expect` syntax
or explicitly enable
`:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead.
Called from /chargebee-ruby/spec/chargebee/list_result_spec.rb:51:in `block (2 levels)
in <top (required)>'.

If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

1 deprecation warning total
evolve2k commented 4 years ago

Always a good idea to keep your test suite syntax up-to-date. Looks good to me. I'd say it's good to merge.

dogweather commented 4 years ago

@evolve2k Chargebee does not respond to or merge PR's. Instead, we just receive spam comments. E.g., https://github.com/chargebee/chargebee-ruby/pull/42 which was closed in frustration. We're on our own for these.

Maybe bring it up with customer service? The last time I really needed a fix done, I contacted cust. service, and they pulled the right strings to make it happen.

cc: @cb-goutham @cb-gaurav

williantenfen commented 2 years ago

@cb-yateshmathuria can you take a look at this as well ?

cb-khushbubibay commented 2 years ago

This PR has been addressed in v2.13.1. Hence closing it.