search

chargebee / chargebee-ruby

Ruby library for the Chargebee API.
https://apidocs.chargebee.com/docs/api?lang=ruby
MIT License
32 stars 60 forks source link

Upgrading rest-client from 2.0.2 to 2.1.0 breaks lots of requests with change in utf-8 encoding #50

Closed tomurb closed 3 years ago

tomurb commented 3 years ago

Just in case you're not aware https://github.com/rest-client/rest-client/issues/740#

I had to set rest-client in my Gemfile to 2.0.2 to avoid this issue.

scottbarrow commented 3 years ago

An update today from chargebee (2.8.5) to chargebee (2.8.6) changed -rest-client (2.0.2) +rest-client (2.1.0)

This now breaks a lot of encoding as per this issue

cb-rakesh commented 3 years ago

1) Version update 2.8.6 doesn't deal with any changes to the dependency rest-client. 2) The rest-client was added as dependancy '>= 1.8', '< 3.0' and this change happened 4 years ago.

An update today from chargebee (2.8.5) to chargebee (2.8.6) changed -rest-client (2.0.2) +rest-client (2.1.0)

This now breaks a lot of encoding as per this issue

scottbarrow commented 3 years ago
  1. Version update 2.8.6 doesn't deal with any changes to the dependency rest-client.
  2. The rest-client was added as dependancy '>= 1.8', '< 3.0' and this change happened 4 years ago.

My git diff begs to differ, this is bundle update chargbee taking 2.8.5 to 2.8.6, you can see that the rest-client bumps from 2.0.2 to 2.1.0 which is a minor version change, however it was actually a major change as per https://github.com/rest-client/rest-client/issues/740

Screen Shot 2021-06-10 at 9 05 12 AM

cb-rakesh commented 3 years ago

@scottbarrow I'm looking into this. Will give you an update soon.

cb-rakesh commented 3 years ago

This has been fixed with version 2.8.7.

loomchild commented 1 week ago

@tomurb Sorry for contacting you after such a long time, but I am trying to upgrade rest-client and can't reproduce the issue. Could you share the reproduction steps and the environment used?

cb-alish commented 1 week ago

Hi @loomchild, please refer to this comment once.