search

chargebee / chargebee-ruby

Ruby library for the Chargebee API.
https://apidocs.chargebee.com/docs/api?lang=ruby
MIT License
32 stars 60 forks source link

Use the latest version of rest-client (why a downgrade!?) #55

Open collimarco opened 3 years ago

collimarco commented 3 years ago

Hello,

Why is there a downgrade of the rest-client gem? Your commit message is empty...

Please clarify the motivation and fix this in order to use the latest version. It is important to use always the latest gem version to avoid bugs and security issues.

cb-rakesh commented 3 years ago

The deprecation has been done to support backward compatibility. We are working on upgrading to the latest version of rest-client in the further releases.

ActualAl commented 2 years ago

Hi there is there any news on this? It's preventing upgrades to other critical gems that require rest_client >= 2.1

jfloff commented 9 months ago

Any updates on this?

callahat commented 7 months ago

Bump

DevStarks commented 3 months ago

Any updates on this? @cb-khushbubibay @cb-rakesh

loomchild commented 2 months ago

@cb-alish Could you please look into this and clarify why the old version of rest-client is needed (sorry to mentioning you directly, but you seem to be the last person who committed to this repo).

cb-alish commented 2 months ago

Hi @loomchild, It seems to have some compatibility issues. Specifically, the rest_client version 2.1.0 includes breaking changes. Please refer to #43 & #50 once.

loomchild commented 2 months ago

Ah, it makes sense, thank you very much for the information. I will investigate what to do (since I also have a conflict with another gem requiring 2.1.0).

loomchild commented 2 months ago

@cb-alish The breaking change seems to be located in https://github.com/rest-client/rest-client/pull/597 and there's a workaround described in https://github.com/rest-client/rest-client/issues/740#issuecomment-778254696. Would you consider implementing it (looks like the change is located only in rest.rb file).

If not, would you potentially accept a PR implementing it? (I would need help in testing the use cases reported in PRs you linked, but can give it a try).

cb-alish commented 2 months ago

Hi @loomchild, sure we'll consider implementing it but it might take a few weeks before we can get to this.

If you'd like to contribute, please create a PR and we can definitely test & include it in the SDK.

loomchild commented 2 months ago

I had some ideas what could be the issue and how to solve it based on https://github.com/rest-client/rest-client/issues/722. But when I have simply tried to bump rest-client to 2.1.0, I was able to retrieve a subscription via (as described in #43):

ChargeBee::Subscription.retrieve(subscription_id).subscription

Could you clarify how to reproduce the issues described in #43 and #50? Do I perhaps need to use a specific version of Ruby? (I tested with 3.3.4 and 2.7.8) Maybe Net::HTTP has evolved so the issues no longer occur?

cb-alish commented 3 days ago

Hi @callahat & @DevStarks could you take a look at #85 when you have a moment? We're transitioning to Net::HTTP with the goal of removing rest-client as a dependency. Just want to make sure everything looks good from your side. Thanks!